From: David Miller <davem@davemloft.net>
To: kafai@fb.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
hannes@stressinduktion.org, kernel-team@fb.com
Subject: Re: [PATCH v4 net 0/5] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel
Date: Tue, 15 Sep 2015 15:02:52 -0700 (PDT) [thread overview]
Message-ID: <20150915.150252.882663449854060859.davem@davemloft.net> (raw)
In-Reply-To: <1442352609-1476011-1-git-send-email-kafai@fb.com>
From: Martin KaFai Lau <kafai@fb.com>
Date: Tue, 15 Sep 2015 14:30:04 -0700
> v4:
> - Fix a compilation error in patch 5 when CONFIG_LOCKDEP is turned on and
> re-test it
>
> v3:
> - Merge a 'if else if' test in patch 4
> - Use rcu_dereference_protected in patch 5 to fix a sparse check when
> CONFIG_SPARSE_RCU_POINTER is enabled
>
> v2:
> - Add patch 4 and 5 to remove the spinlock
>
> v1:
> This patch series is to fix the dst refcnt bugs in ip6_tunnel.
>
> Patch 1 and 2 are the prep works. Patch 3 is the fix.
>
> I can reproduce the bug by adding and removing the ip6gre tunnel
> while running a super_netperf TCP_CRR test. I get the following
> trace by adding WARN_ON_ONCE(newrefcnt < 0) to dst_release():
...
Series applied, thanks.
prev parent reply other threads:[~2015-09-15 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 21:30 [PATCH v4 net 0/5] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel Martin KaFai Lau
2015-09-15 21:30 ` [PATCH v4 net 1/5] ipv6: Refactor common ip6gre_tunnel_init codes Martin KaFai Lau
2015-09-15 21:30 ` [PATCH v4 net 2/5] ipv6: Rename the dst_cache helper functions in ip6_tunnel Martin KaFai Lau
2015-09-15 21:30 ` [PATCH v4 net 3/5] ipv6: Fix dst_entry refcnt bugs " Martin KaFai Lau
2015-09-15 21:30 ` [PATCH v4 net 4/5] ipv6: Avoid double dst_free Martin KaFai Lau
2015-09-15 21:30 ` [PATCH v4 net 5/5] ipv6: Replace spinlock with seqlock and rcu in ip6_tunnel Martin KaFai Lau
2015-09-15 22:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915.150252.882663449854060859.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).