From: David Miller <davem@davemloft.net>
To: sjoerd.simons@collabora.co.uk
Cc: peppe.cavallaro@st.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: stmmac: Use msleep rather then udelay for reset delay
Date: Tue, 15 Sep 2015 15:05:48 -0700 (PDT) [thread overview]
Message-ID: <20150915.150548.1197620792036413505.davem@davemloft.net> (raw)
In-Reply-To: <1442003149-10717-1-git-send-email-sjoerd.simons@collabora.co.uk>
From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date: Fri, 11 Sep 2015 22:25:48 +0200
> The reset delays used for stmmac are in the order of 10ms to 1 second,
> which is far too long for udelay usage, so switch to using msleep.
>
> Practically this fixes the PHY not being reliably detected in some cases
> as udelay wouldn't actually delay for long enough to let the phy
> reliably be reset.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Applied, thanks.
prev parent reply other threads:[~2015-09-15 22:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 20:25 [PATCH v2] net: stmmac: Use msleep rather then udelay for reset delay Sjoerd Simons
2015-09-15 22:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915.150548.1197620792036413505.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).