From: David Miller <davem@davemloft.net>
To: jesse@nicira.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net v2] openvswitch: Fix mask generation for nested attributes.
Date: Tue, 15 Sep 2015 16:25:52 -0700 (PDT) [thread overview]
Message-ID: <20150915.162552.1124834423380189803.davem@davemloft.net> (raw)
In-Reply-To: <1442021908-47034-1-git-send-email-jesse@nicira.com>
From: Jesse Gross <jesse@nicira.com>
Date: Fri, 11 Sep 2015 18:38:28 -0700
> Masks were added to OVS flows in a way that was backwards compatible
> with userspace programs that did not generate masks. As a result, it is
> possible that we may receive flows that do not have a mask and we need
> to synthesize one.
>
> Generating a mask requires iterating over attributes and descending into
> nested attributes. For each level we need to know the size to generate the
> correct mask. We do this with a linked table of attribute types.
>
> Although the logic to handle these nested attributes was there in concept,
> there are a number of bugs in practice. Examples include incomplete links
> between tables, variable length attributes being treated as nested and
> missing sanity checks.
>
> Signed-off-by: Jesse Gross <jesse@nicira.com>
> ---
> v2: Fix whitespace errors.
> Add check for unknown bytes in VXLAN extensions.
> Factor out check for nested or variable attributes.
Applied, thanks.
prev parent reply other threads:[~2015-09-15 23:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-12 1:38 [PATCH net v2] openvswitch: Fix mask generation for nested attributes Jesse Gross
2015-09-13 0:04 ` Pravin Shelar
2015-09-15 23:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915.162552.1124834423380189803.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).