From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH V3 2/2] debugfs: don't assume sizeof(bool) to be 4 bytes Date: Tue, 15 Sep 2015 10:29:29 -0400 Message-ID: <20150915142929.GB2905@mtj.duckdns.org> References: <9b705747a138c96c26faee5218f7b47403195b28.1442305897.git.viresh.kumar@linaro.org> <27d37898b4be6b9b9f31b90135f8206ca079a868.1442305897.git.viresh.kumar@linaro.org> <20150915100454.70dcc04d@gandalf.local.home> <20150915141208.GK6350@linux> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "open list:NETWORKING DRIVERS \(WIRELESS\)" , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Avri Altman , Stanislaw Gruszka , Jiri Slaby , "open list:DOCUMENTATION" , Peter Zijlstra , Catalin Marinas , Sebastian Andrzej Siewior , Will Deacon , Jaroslav Kysela , "open list:MEMORY MANAGEMENT" , Kalle Valo , Emmanuel Grumbach , Luciano Coelho , Wang Long , Richard Fitzgerald , Ingo Molnar , open list Return-path: Content-Disposition: inline In-Reply-To: <20150915141208.GK6350@linux> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: netdev.vger.kernel.org Hello, On Tue, Sep 15, 2015 at 07:42:08PM +0530, Viresh Kumar wrote: > Ah, yes. Thanks for letting me know (I just testedit as well). > > But will it look sane enough to set a boolean to anything apart from > true/false or 1/0? Yes, it will always be set to 0/1 only, but still.. Let's please not do something unnecessary. Everybody has different ideas about what looks natural and the best way to achieve some semblance of consistency is sticking with minimum unless there are overriding concerns and there isn't any here. Thanks. -- tejun