From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: Fix vti use case with oif in dst lookups
Date: Wed, 16 Sep 2015 10:21:14 +0200 [thread overview]
Message-ID: <20150916082114.GA7701@secunet.com> (raw)
In-Reply-To: <1442355050-9214-1-git-send-email-dsa@cumulusnetworks.com>
On Tue, Sep 15, 2015 at 03:10:50PM -0700, David Ahern wrote:
> Steffen reported that the recent change to add oif to dst lookups breaks
> the VTI use case. The problem is that with the oif set in the flow struct
> the comparison to the nh_oif is triggered. Fix by splitting the
> FLOWI_FLAG_VRFSRC into 2 flags -- one that triggers the vrf device cache
> bypass (FLOWI_FLAG_VRFSRC) and another telling the lookup to not compare
> nh oif (FLOWI_FLAG_SKIP_NH_OIF).
>
> Fixes: 42a7b32b73d6 ("xfrm: Add oif to dst lookups")
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
This works, thanks a lot for the quick fix!
> ---
> IPv6 does not show this problem for me. So no change is added for IPv6.
> If your mileage varies let me know and I'll take another look.
IPv6 works just fine as it is, so no change needed.
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
next prev parent reply other threads:[~2015-09-16 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 22:10 [PATCH] net: Fix vti use case with oif in dst lookups David Ahern
2015-09-16 8:21 ` Steffen Klassert [this message]
2015-09-17 23:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916082114.GA7701@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).