[PATCH] net: qdisc: enhance default_qdisc documentation

[PATCH] net: qdisc: enhance default_qdisc documentation

[Phil Sutter]

Aside from some lingual cleanup, point out which interfaces are not or
partly covered by this setting.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 Documentation/sysctl/net.txt | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/Documentation/sysctl/net.txt b/Documentation/sysctl/net.txt
index 6294b51..809ab6e 100644
--- a/Documentation/sysctl/net.txt
+++ b/Documentation/sysctl/net.txt
@@ -54,13 +54,15 @@ default_qdisc
 --------------
 
 The default queuing discipline to use for network devices. This allows
-overriding the default queue discipline of pfifo_fast with an
-alternative. Since the default queuing discipline is created with the
-no additional parameters so is best suited to queuing disciplines that
-work well without configuration like stochastic fair queue (sfq),
-CoDel (codel) or fair queue CoDel (fq_codel). Don't use queuing disciplines
-like Hierarchical Token Bucket or Deficit Round Robin which require setting
-up classes and bandwidths.
+overriding the default of pfifo_fast with an alternative. Since the default
+queuing discipline is created without additional parameters so is best suited
+to queuing disciplines that work well without configuration like stochastic
+fair queue (sfq), CoDel (codel) or fair queue CoDel (fq_codel). Don't use
+queuing disciplines like Hierarchical Token Bucket or Deficit Round Robin
+which require setting up classes and bandwidths. Note that physical multiqueue
+interfaces still use mq as root qdisc, which in turn uses this default for its
+leaves. Virtual devices (like e.g. lo or veth) ignore this setting and instead
+default to noqueue.
 Default: pfifo_fast
 
 busy_read
-- 
2.1.2

Re: [PATCH] net: qdisc: enhance default_qdisc documentation

[Cong Wang]

On Tue, Sep 15, 2015 at 1:33 AM, Phil Sutter <phil@nwl.cc> wrote:
> Aside from some lingual cleanup, point out which interfaces are not or
> partly covered by this setting.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Acked-by: Cong Wang <cwang@twopensource.com>

It also worth to explain what the default qdisc means, but we can do
that in another patch.

Thanks.

Re: [PATCH] net: qdisc: enhance default_qdisc documentation

[David Miller]

From: Phil Sutter <phil@nwl.cc>
Date: Tue, 15 Sep 2015 10:33:07 +0200

> Aside from some lingual cleanup, point out which interfaces are not or
> partly covered by this setting.
> 
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Applied.