* [PATCH net 1/6] lan78xx: Check device ready bit (PMT_CTL_READY_) after reset the PHY
@ 2015-09-16 23:40 Woojung.Huh
2015-09-18 5:16 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Woojung.Huh @ 2015-09-16 23:40 UTC (permalink / raw)
To: davem; +Cc: netdev
Check device ready bit (PMT_CTL_READY_) after reset the PHY.
Device may not be ready even if PHY_RST_ is cleared depends on configuration.
Signed-off-by: Woojung Huh <woojung.huh@microchip.com>
---
drivers/net/usb/lan78xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index a39518f..d0d8790 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -2002,7 +2002,7 @@ static int lan78xx_reset(struct lan78xx_net *dev)
netdev_warn(dev->net, "timeout waiting for PHY Reset");
return -EIO;
}
- } while (buf & PMT_CTL_PHY_RST_);
+ } while ((buf & PMT_CTL_PHY_RST_) || !(buf & PMT_CTL_READY_));
lan78xx_mii_init(dev);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net 1/6] lan78xx: Check device ready bit (PMT_CTL_READY_) after reset the PHY
2015-09-16 23:40 [PATCH net 1/6] lan78xx: Check device ready bit (PMT_CTL_READY_) after reset the PHY Woojung.Huh
@ 2015-09-18 5:16 ` David Miller
2015-09-18 13:45 ` Woojung.Huh
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2015-09-18 5:16 UTC (permalink / raw)
To: Woojung.Huh; +Cc: netdev
All 6 patches applied, thanks.
But in the future, please provide an initial "[PATCH net 0/6]" posting which
gives a top-level overview of what your patch series is doing.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH net 1/6] lan78xx: Check device ready bit (PMT_CTL_READY_) after reset the PHY
2015-09-18 5:16 ` David Miller
@ 2015-09-18 13:45 ` Woojung.Huh
0 siblings, 0 replies; 3+ messages in thread
From: Woojung.Huh @ 2015-09-18 13:45 UTC (permalink / raw)
To: davem; +Cc: netdev
Thanks David,
I'll add overview "[PATCH net 0/#]" next time.
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Friday, September 18, 2015 1:16 AM
> To: Woojung Huh - C21699
> Cc: netdev@vger.kernel.org
> Subject: Re: [PATCH net 1/6] lan78xx: Check device ready bit
> (PMT_CTL_READY_) after reset the PHY
>
>
> All 6 patches applied, thanks.
>
> But in the future, please provide an initial "[PATCH net 0/6]" posting which
> gives a top-level overview of what your patch series is doing.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-18 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 23:40 [PATCH net 1/6] lan78xx: Check device ready bit (PMT_CTL_READY_) after reset the PHY Woojung.Huh
2015-09-18 5:16 ` David Miller
2015-09-18 13:45 ` Woojung.Huh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).