From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>
Cc: <dan.streetman@canonical.com>, <ddstreet@ieee.org>,
<jay.vosburgh@canonical.com>, <netdev@vger.kernel.org>
Subject: Re: xfrm4_garbage_collect reaching limit
Date: Fri, 18 Sep 2015 06:49:43 +0200 [thread overview]
Message-ID: <20150918044943.GC7701@secunet.com> (raw)
In-Reply-To: <20150917.212335.346651920275379240.davem@davemloft.net>
On Thu, Sep 17, 2015 at 09:23:35PM -0700, David Miller wrote:
> From: Steffen Klassert <steffen.klassert@secunet.com>
> Date: Wed, 16 Sep 2015 10:45:41 +0200
>
> > index 1e06c4f..3dffc73 100644
> > --- a/net/ipv4/xfrm4_policy.c
> > +++ b/net/ipv4/xfrm4_policy.c
> > @@ -248,7 +248,7 @@ static struct dst_ops xfrm4_dst_ops = {
> > .destroy = xfrm4_dst_destroy,
> > .ifdown = xfrm4_dst_ifdown,
> > .local_out = __ip_local_out,
> > - .gc_thresh = 32768,
> > + .gc_thresh = INT_MAX,
> > };
> >
> > static struct xfrm_policy_afinfo xfrm4_policy_afinfo = {
>
> This means the dst_ops->gc() for xfrm will never be invoked.
>
> Is that intentional?
Yes. This is already the case on systems with less than 8 cpus
because the flowcache is limited to 4096 entries per cpu. The
percpu flowcache shrinks itself to 'low_watermark' enrires if
it hits the percpu limit.
next prev parent reply other threads:[~2015-09-18 4:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 21:01 xfrm4_garbage_collect reaching limit Dan Streetman
2015-09-11 9:48 ` Steffen Klassert
2015-09-15 3:14 ` Dan Streetman
2015-09-16 8:45 ` Steffen Klassert
2015-09-18 4:23 ` David Miller
2015-09-18 4:49 ` Steffen Klassert [this message]
2015-09-18 5:00 ` Dan Streetman
2015-09-21 14:51 ` Dan Streetman
2015-09-30 9:54 ` Steffen Klassert
2015-09-21 14:52 ` Dan Streetman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918044943.GC7701@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=dan.streetman@canonical.com \
--cc=davem@davemloft.net \
--cc=ddstreet@ieee.org \
--cc=jay.vosburgh@canonical.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).