From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com,
eladr@mellanox.com, sfeldma@gmail.com, f.fainelli@gmail.com,
linux@roeck-us.net
Subject: Re: [patch net-next RFC 3/6] rocker: switch to local transaction phase enum
Date: Sat, 19 Sep 2015 15:25:04 -0400 [thread overview]
Message-ID: <20150919192504.GB4907@ketchup> (raw)
In-Reply-To: <1442665751-10949-4-git-send-email-jiri@resnulli.us>
Hi Jiri,
On Sep. Saturday 19 (38) 02:29 PM, Jiri Pirko wrote:
> Since switchdev_trans_ph anum is going to be removed, and rocker code is
> way too complicated in this matter to be converted, just introduce local
> enum for transaction phase. Pass it around in local transaction
> structure.
I missed this typo here: s/anum/enum/.
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
I found the renaming trick is a bit hard to follow. I am wondering if
this patch could be used first and drop patch 1/6?
That way, you can first add the rocker_trans structure and set its ph
member to obj->trans in obj_add/attr_set, then the following patch
(currently 2/6) would just assign it to the new trans parameter.
Thanks,
-v
next prev parent reply other threads:[~2015-09-19 19:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-19 12:29 [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split Jiri Pirko
2015-09-19 12:29 ` [patch net-next RFC 1/6] switchdev: rename "trans" to "trans_ph" Jiri Pirko
2015-09-19 12:29 ` [patch net-next RFC 2/6] switchdev: introduce transaction infrastructure for attr_set and obj_add Jiri Pirko
2015-09-19 12:29 ` [patch net-next RFC 3/6] rocker: switch to local transaction phase enum Jiri Pirko
2015-09-19 19:25 ` Vivien Didelot [this message]
2015-09-20 8:59 ` Jiri Pirko
2015-09-19 12:29 ` [patch net-next RFC 4/6] switchdev: move transaction phase enum under transaction structure Jiri Pirko
2015-09-19 12:29 ` [patch net-next RFC 5/6] rocker: use switchdev transaction queue for allocated memory Jiri Pirko
2015-09-19 12:29 ` [patch net-next RFC 6/6] switchdev: split commit and prepare phase into two callbacks Jiri Pirko
2015-09-19 13:35 ` [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split Rosen, Rami
2015-09-19 16:23 ` Jiri Pirko
2015-09-19 19:02 ` Vivien Didelot
2015-09-20 8:33 ` Jiri Pirko
2015-09-19 17:46 ` Scott Feldman
2015-09-20 8:34 ` Jiri Pirko
2015-09-21 7:23 ` Scott Feldman
2015-09-21 8:09 ` Jiri Pirko
2015-09-21 16:34 ` Scott Feldman
2015-09-21 19:06 ` Jiri Pirko
2015-09-21 17:13 ` Vivien Didelot
2015-09-21 18:25 ` Jiri Pirko
2015-09-22 1:36 ` Vivien Didelot
2015-09-22 6:12 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150919192504.GB4907@ketchup \
--to=vivien.didelot@savoirfairelinux.com \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox