From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: linux-kernel@vger.kernel.org, mjrosato@linux.vnet.ibm.com,
borntraeger@de.ibm.com, viro@zeniv.linux.org.uk,
jasowang@redhat.com, david@gibson.dropbear.id.au,
gkurz@linux.vnet.ibm.com, vyasevich@gmail.com,
justin@myriabit.com, herbert@gondor.apana.org.au,
netdev@vger.kernel.org
Subject: Re: [PATCH] macvtap: fix TUNSETSNDBUF values > 64k
Date: Sun, 20 Sep 2015 22:45:12 -0700 (PDT) [thread overview]
Message-ID: <20150920.224512.1934479578463693954.davem@davemloft.net> (raw)
In-Reply-To: <1442572808-6438-1-git-send-email-mst@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Fri, 18 Sep 2015 13:41:09 +0300
> Upon TUNSETSNDBUF, macvtap reads the requested sndbuf size into
> a local variable u.
> commit 39ec7de7092b ("macvtap: fix uninitialized access on
> TUNSETIFF") changed its type to u16 (which is the right thing to
> do for all other macvtap ioctls), breaking all values > 64k.
>
> The value of TUNSETSNDBUF is actually a signed 32 bit integer, so
> the right thing to do is to read it into an int.
>
> Cc: David S. Miller <davem@davemloft.net>
> Fixes: 39ec7de7092b ("macvtap: fix uninitialized access on TUNSETIFF")
> Reported-by: Mark A. Peloquin
> Bisected-by: Matthew Rosato <mjrosato@linux.vnet.ibm.com>
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2015-09-21 5:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 10:41 [PATCH] macvtap: fix TUNSETSNDBUF values > 64k Michael S. Tsirkin
2015-09-18 10:49 ` Christian Borntraeger
2015-09-18 10:50 ` Michael S. Tsirkin
2015-09-21 5:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150920.224512.1934479578463693954.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=borntraeger@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=gkurz@linux.vnet.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=justin@myriabit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjrosato@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).