From: David Miller <davem@davemloft.net>
To: jesse@nicira.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] openvswitch: Zero flows on allocation.
Date: Sun, 20 Sep 2015 23:24:00 -0700 (PDT) [thread overview]
Message-ID: <20150920.232400.1768865193135146379.davem@davemloft.net> (raw)
In-Reply-To: <1442628374-57025-1-git-send-email-jesse@nicira.com>
From: Jesse Gross <jesse@nicira.com>
Date: Fri, 18 Sep 2015 19:06:14 -0700
> @@ -80,7 +80,7 @@ struct sw_flow *ovs_flow_alloc(void)
> struct flow_stats *stats;
> int node;
>
> - flow = kmem_cache_alloc(flow_cache, GFP_KERNEL);
> + flow = kmem_cache_alloc(flow_cache, GFP_KERNEL | __GFP_ZERO);
> if (!flow)
Like Eric, I prefer that you use kmem_cache_zalloc() to fix
this.
Thanks.
next prev parent reply other threads:[~2015-09-21 6:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-19 2:06 [PATCH net] openvswitch: Zero flows on allocation Jesse Gross
2015-09-19 3:38 ` Pravin Shelar
2015-09-20 16:32 ` Eric Dumazet
2015-09-21 6:24 ` David Miller [this message]
2015-09-22 1:11 ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150920.232400.1768865193135146379.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).