netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] ARCNET: refactoring and cleanup
@ 2015-09-21 15:11 Michael Grzeschik
  2015-09-21 17:40 ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Grzeschik @ 2015-09-21 15:11 UTC (permalink / raw)
  To: davem; +Cc: netdev

Hi David,

The following changes since commit 1f93e4a96c9109378204c147b3eec0d0e8100fde:

  Linux 4.3-rc2 (2015-09-20 14:32:34 -0700)

are available in the git repository at:

  git://git.pengutronix.de/git/mgr/linux.git tags/arcnet-cleanup-v4.3-rc2

for you to fetch changes up to 9ac23e159ab81450d7c644b13a271b514d2bcc23:

  arcnet: capmode: remove extra function (2015-09-21 16:36:30 +0200)

----------------------------------------------------------------
ARCNET: refactoring and cleanup

This series cleans up the code in drivers/net/arcnet
and include/uapi/linux/if_arcnet.h . It doesn't change
the runtime behaviour of the code. Its only purpose
is to improve the code maintenance and readability.

----------------------------------------------------------------
Joe Perches (29):
      ARCNET: fix indentation of if_arcnet.h
      arcnet: Use normal kernel spacing style
      arcnet: Add and remove blank lines
      arcnet: Use normal kernel brace style
      arcnet: Coalesce string fragments
      arcnet: Use include/linux path for asm
      arcnet: Use network block comment style
      arcnet: Neaten BUGMSG macro defines
      arcnet: Expand odd BUGLVL macro with if and uses
      arcnet: Convert BUGMSG and BUGMSG2 to arc_prink and arc_cont
      arcnet: Convert printk to pr_<level>
      arcnet: Move EXPORT_SYMBOL after declarations
      arcnet: Remove unnecessary OOM messages
      arcnet: Remove assignments from ifs
      arcnet: Remove pointer comparisons to NULL
      arcnet: Convert arcnet_dump_skb macro to static inline
      arcnet: Wrap some long lines
      arcnet: Move files out of include/linux
      arcnet: Make a char * array const char * const
      arcnet: Add arcnet_<I/O> macros
      arcnet: com20020: Use arcnet_<I/O> routines
      arcnet: com90io: Use arcnet_<I/O> routines
      arcnet: com90xx: Use arcnet_<I/O> routines
      arcnet: arcdevice.h: Add arcnet_readb and arcnet_writeb
      arcnet: arc-rimi: Use arcnet_<I/O> routines
      arcnet: com90xx: Use arcnet_readb/writeb routines
      arcnet: Remove function pointer macro indirections
      arcnet: Add com9026.h to standardize COM9026_REG_<foo>
      arcnet: Remove unused arcnet_<I/O>w macros

Michael Grzeschik (4):
      arcnet: reformat structs to C99 format
      arcnet: com20020: replace magic numbers with readable macros
      arcnet: arc-rawmode: reorder module functions
      arcnet: capmode: remove extra function

 MAINTAINERS                                       |   1 -
 drivers/net/arcnet/arc-rawmode.c                  | 142 +++--
 drivers/net/arcnet/arc-rimi.c                     | 145 +++---
 {include/linux => drivers/net/arcnet}/arcdevice.h | 152 +++---
 drivers/net/arcnet/arcnet.c                       | 601 ++++++++++------------
 drivers/net/arcnet/capmode.c                      | 138 +++--
 drivers/net/arcnet/com20020-isa.c                 |  54 +-
 drivers/net/arcnet/com20020-pci.c                 |  70 ++-
 drivers/net/arcnet/com20020.c                     | 234 +++++----
 {include/linux => drivers/net/arcnet}/com20020.h  |  75 +--
 drivers/net/arcnet/com20020_cs.c                  | 325 ++++++------
 drivers/net/arcnet/com9026.h                      |  17 +
 drivers/net/arcnet/com90io.c                      | 209 ++++----
 drivers/net/arcnet/com90xx.c                      | 323 ++++++------
 drivers/net/arcnet/rfc1051.c                      |  77 ++-
 drivers/net/arcnet/rfc1201.c                      | 238 ++++-----
 include/uapi/linux/if_arcnet.h                    |  55 +-
 17 files changed, 1410 insertions(+), 1446 deletions(-)
 rename {include/linux => drivers/net/arcnet}/arcdevice.h (79%)
 rename {include/linux => drivers/net/arcnet}/com20020.h (61%)
 create mode 100644 drivers/net/arcnet/com9026.h

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] ARCNET: refactoring and cleanup
  2015-09-21 15:11 [GIT PULL] ARCNET: refactoring and cleanup Michael Grzeschik
@ 2015-09-21 17:40 ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2015-09-21 17:40 UTC (permalink / raw)
  To: mgr; +Cc: netdev

From: Michael Grzeschik <mgr@pengutronix.de>
Date: Mon, 21 Sep 2015 17:11:54 +0200

> The following changes since commit 1f93e4a96c9109378204c147b3eec0d0e8100fde:
> 
>   Linux 4.3-rc2 (2015-09-20 14:32:34 -0700)
> 
> are available in the git repository at:
> 
>   git://git.pengutronix.de/git/mgr/linux.git tags/arcnet-cleanup-v4.3-rc2
> 
> for you to fetch changes up to 9ac23e159ab81450d7c644b13a271b514d2bcc23:
> 
>   arcnet: capmode: remove extra function (2015-09-21 16:36:30 +0200)

I think for a subsystem such as ARCNET, you should also post all of
the patches here for a full review, and not just give a plain pull
request.

Thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [GIT PULL] ARCNET: refactoring and cleanup
@ 2015-09-22  9:01 Michael Grzeschik
  2015-09-23  0:25 ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Grzeschik @ 2015-09-22  9:01 UTC (permalink / raw)
  To: davem; +Cc: netdev, joe, kernel

The following changes since commit 1f93e4a96c9109378204c147b3eec0d0e8100fde:

  Linux 4.3-rc2 (2015-09-20 14:32:34 -0700)

are available in the git repository at:

  git://git.pengutronix.de/git/mgr/linux.git tags/arcnet-cleanup-v4.3-rc2

for you to fetch changes up to 9ac23e159ab81450d7c644b13a271b514d2bcc23:

  arcnet: capmode: remove extra function (2015-09-21 16:36:30 +0200)

----------------------------------------------------------------
ARCNET: refactoring and cleanup

This series cleans up the code in drivers/net/arcnet
and include/uapi/linux/if_arcnet.h . It doesn't change
the runtime behaviour of the code. Its only purpose
is to improve the code maintenance and readability.

----------------------------------------------------------------
Joe Perches (29):
  arcnet: fix indentation of if_arcnet.h
  arcnet: Use normal kernel spacing style
  arcnet: Add and remove blank lines
  arcnet: Use normal kernel brace style
  arcnet: Coalesce string fragments
  arcnet: Use include/linux path for asm
  arcnet: Use network block comment style
  arcnet: Neaten BUGMSG macro defines
  arcnet: Expand odd BUGLVL macro with if and uses
  arcnet: Convert BUGMSG and BUGMSG2 to arc_prink and arc_cont
  arcnet: Convert printk to pr_<level>
  arcnet: Move EXPORT_SYMBOL after declarations
  arcnet: Remove unnecessary OOM messages
  arcnet: Remove assignments from ifs
  arcnet: Remove pointer comparisons to NULL
  arcnet: Convert arcnet_dump_skb macro to static inline
  arcnet: Wrap some long lines
  arcnet: Move files out of include/linux
  arcnet: Make a char * array const char * const
  arcnet: Add arcnet_<I/O> macros
  arcnet: com20020: Use arcnet_<I/O> routines
  arcnet: com90io: Use arcnet_<I/O> routines
  arcnet: com90xx: Use arcnet_<I/O> routines
  arcnet: arcdevice.h: Add arcnet_readb and arcnet_writeb
  arcnet: arc-rimi: Use arcnet_<I/O> routines
  arcnet: com90xx: Use arcnet_readb/writeb routines
  arcnet: Remove function pointer macro indirections
  arcnet: Add com9026.h to standardize COM9026_REG_<foo>
  arcnet: Remove unused arcnet_<I/O>w macros

Michael Grzeschik (4):
  arcnet: reformat structs to C99 format
  arcnet: com20020: replace magic numbers with readable macros
  arcnet: arc-rawmode: reorder module functions
  arcnet: capmode: remove extra function

 MAINTAINERS                                       |   1 -
 drivers/net/arcnet/arc-rawmode.c                  | 142 +++--
 drivers/net/arcnet/arc-rimi.c                     | 145 +++---
 {include/linux => drivers/net/arcnet}/arcdevice.h | 152 +++---
 drivers/net/arcnet/arcnet.c                       | 601 ++++++++++------------
 drivers/net/arcnet/capmode.c                      | 138 +++--
 drivers/net/arcnet/com20020-isa.c                 |  54 +-
 drivers/net/arcnet/com20020-pci.c                 |  70 ++-
 drivers/net/arcnet/com20020.c                     | 234 +++++----
 {include/linux => drivers/net/arcnet}/com20020.h  |  75 +--
 drivers/net/arcnet/com20020_cs.c                  | 325 ++++++------
 drivers/net/arcnet/com9026.h                      |  17 +
 drivers/net/arcnet/com90io.c                      | 209 ++++----
 drivers/net/arcnet/com90xx.c                      | 323 ++++++------
 drivers/net/arcnet/rfc1051.c                      |  77 ++-
 drivers/net/arcnet/rfc1201.c                      | 238 ++++-----
 include/uapi/linux/if_arcnet.h                    |  55 +-
 17 files changed, 1410 insertions(+), 1446 deletions(-)
 rename {include/linux => drivers/net/arcnet}/arcdevice.h (79%)
 rename {include/linux => drivers/net/arcnet}/com20020.h (61%)
 create mode 100644 drivers/net/arcnet/com9026.h

-- 
2.5.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] ARCNET: refactoring and cleanup
  2015-09-22  9:01 Michael Grzeschik
@ 2015-09-23  0:25 ` David Miller
  2015-09-23  9:20   ` Michael Grzeschik
  0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2015-09-23  0:25 UTC (permalink / raw)
  To: m.grzeschik; +Cc: netdev, joe, kernel

From: Michael Grzeschik <m.grzeschik@pengutronix.de>
Date: Tue, 22 Sep 2015 11:01:41 +0200

>   git://git.pengutronix.de/git/mgr/linux.git tags/arcnet-cleanup-v4.3-rc2

Please build this tree against net-next, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] ARCNET: refactoring and cleanup
  2015-09-23  0:25 ` David Miller
@ 2015-09-23  9:20   ` Michael Grzeschik
  2015-09-23 21:27     ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Grzeschik @ 2015-09-23  9:20 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, joe, kernel

On Tue, Sep 22, 2015 at 05:25:03PM -0700, David Miller wrote:
> From: Michael Grzeschik <m.grzeschik@pengutronix.de>
> Date: Tue, 22 Sep 2015 11:01:41 +0200
> 
> >   git://git.pengutronix.de/git/mgr/linux.git tags/arcnet-cleanup-v4.3-rc2
> 
> Please build this tree against net-next, thanks.

Done that now. Shall I resend the pull?


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] ARCNET: refactoring and cleanup
  2015-09-23  9:20   ` Michael Grzeschik
@ 2015-09-23 21:27     ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2015-09-23 21:27 UTC (permalink / raw)
  To: mgr; +Cc: netdev, joe, kernel

From: Michael Grzeschik <mgr@pengutronix.de>
Date: Wed, 23 Sep 2015 11:20:02 +0200

> On Tue, Sep 22, 2015 at 05:25:03PM -0700, David Miller wrote:
>> From: Michael Grzeschik <m.grzeschik@pengutronix.de>
>> Date: Tue, 22 Sep 2015 11:01:41 +0200
>> 
>> >   git://git.pengutronix.de/git/mgr/linux.git tags/arcnet-cleanup-v4.3-rc2
>> 
>> Please build this tree against net-next, thanks.
> 
> Done that now. Shall I resend the pull?

No need, I pulled it just now, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-09-23 21:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-21 15:11 [GIT PULL] ARCNET: refactoring and cleanup Michael Grzeschik
2015-09-21 17:40 ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2015-09-22  9:01 Michael Grzeschik
2015-09-23  0:25 ` David Miller
2015-09-23  9:20   ` Michael Grzeschik
2015-09-23 21:27     ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).