From: Phil Sutter <phil@nwl.cc>
To: Christoph Schulz <develop@kristov.de>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, Wilhelm Wijkander <lists@0x5e.se>,
Vadim Kochan <vadim4j@gmail.com>
Subject: Re: [iproute2 PATCH] ip-link: do not support 'ip link add dev help'
Date: Mon, 21 Sep 2015 22:26:59 +0200 [thread overview]
Message-ID: <20150921202659.GU24212@orbit.nwl.cc> (raw)
In-Reply-To: <20150921221349.83034aoqadvokjr1@berry.schulz.ip-v6.eu>
On Mon, Sep 21, 2015 at 10:13:49PM +0200, Christoph Schulz wrote:
> Phil Sutter schrieb am Mon, 21 Sep 2015 21:33:01 +0200:
>
> > Commit 0532555 ('Support "ip link add help" for rtnl_link API') added a
> > check for specified help parameter. Though due to the place where it has
> > been added to, it is not possible anymore to force a given parameter to
> > be interpreted as interface name by prefixing it with 'dev '. Fix this
> > by forcing whatever follows 'dev' to be presumed as interface name.
>
> I proposed a similar fix which also handles other ip commands, see
> http://patchwork.ozlabs.org/patch/519171/ . Does my patch also work
> for you?
Yes, this works just as well. Although I would personally prefer
reordering the conditionals, but that's probably just a matter of taste.
Cheers, Phil
prev parent reply other threads:[~2015-09-21 20:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 19:55 iproute2 tunnel name parsing Wilhelm Wijkander
2015-09-17 20:10 ` Vadim Kochan
2015-09-17 23:53 ` Wilhelm Wijkander
2015-09-21 19:33 ` [iproute2 PATCH] ip-link: do not support 'ip link add dev help' Phil Sutter
2015-09-21 20:13 ` Christoph Schulz
2015-09-21 20:26 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921202659.GU24212@orbit.nwl.cc \
--to=phil@nwl.cc \
--cc=develop@kristov.de \
--cc=lists@0x5e.se \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vadim4j@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).