From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ariel.elior@qlogic.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] bnx2x: add ethtool support to read and change RSS key
Date: Tue, 22 Sep 2015 14:59:35 -0700 (PDT) [thread overview]
Message-ID: <20150922.145935.2262486270670808983.davem@davemloft.net> (raw)
In-Reply-To: <1442614912.14037.23.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 18 Sep 2015 15:21:52 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> While trying to understand why bnx2x RSS hash was not matching
> Toeplitz specifications, I implemented driver code to support
> ethtool -x|-X to try various RSS key combinations easily.
>
> Then, after some debugging, I understood bnx2x was reading the rss_key
> in reverse order.
>
> If we want consistent Toeplitz hashes with different NIC, we need
> to byte swap user key.
>
> Tested:
...
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
next prev parent reply other threads:[~2015-09-22 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 22:21 [PATCH net-next] bnx2x: add ethtool support to read and change RSS key Eric Dumazet
2015-09-22 21:59 ` David Miller [this message]
2015-09-22 23:06 ` David Miller
2015-09-22 23:34 ` Eric Dumazet
2015-09-23 0:04 ` [PATCH net] bnx2x: byte swap rss_key to comply to Toeplitz specs Eric Dumazet
2015-09-24 21:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922.145935.2262486270670808983.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariel.elior@qlogic.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).