netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ivan@ru.ibm.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	benh@kernel.crashing.org, ben@decadent.org.uk
Subject: Re: [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool
Date: Wed, 23 Sep 2015 11:05:49 -0700 (PDT)	[thread overview]
Message-ID: <20150923.110549.113067983983388057.davem@davemloft.net> (raw)
In-Reply-To: <20150923144222.66de305c@fr-ThinkPad-W520>

From: Ivan Mikhaylov <ivan@ru.ibm.com>
Date: Wed, 23 Sep 2015 14:42:22 +0400

> Register dump out work preventing with 
> old ethtool + new driver and new ethtool + old driver.

First of all you didn't provide a proper Signoff.

Second of all, there was so much discussion about whether this does
or does not break things for various combinations of old/new ethtool
and kernel.

Therefore I want a real detailed commit message that explains why this
is all OK.  After so much confusion and discussion, providing a patch
with absolutely no commit message is completely inappropriate.

  reply	other threads:[~2015-09-23 18:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-23 10:42 [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool Ivan Mikhaylov
2015-09-23 18:05 ` David Miller [this message]
2015-09-23 19:03   ` Ben Hutchings
2015-09-25  4:07   ` Ivan Mikhaylov
2015-09-25  5:53     ` David Miller
2015-09-25  7:53       ` Ivan Mikhaylov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150923.110549.113067983983388057.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ben@decadent.org.uk \
    --cc=benh@kernel.crashing.org \
    --cc=ivan@ru.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).