From: David Miller <davem@davemloft.net>
To: pch@ordbogen.com
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net
Subject: Re: [PATCH v4 net-next 1/2] ipv4: L3 hash-based multipath
Date: Wed, 23 Sep 2015 14:55:21 -0700 (PDT) [thread overview]
Message-ID: <20150923.145521.609102724670024669.davem@davemloft.net> (raw)
In-Reply-To: <1443037777-25390-2-git-send-email-pch@ordbogen.com>
From: Peter Nørlund <pch@ordbogen.com>
Date: Wed, 23 Sep 2015 21:49:36 +0200
> +static inline int fib_multipath_hash(__be32 saddr, __be32 daddr)
> +{
> + return jhash_2words(saddr, daddr, fib_multipath_secret) >> 1;
> +}
Like Tom I'm curious why you do this shift here?
next prev parent reply other threads:[~2015-09-23 21:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 19:49 [PATCH v4 net-next 0/2] ipv4: Hash-based multipath routing Peter Nørlund
2015-09-23 19:49 ` [PATCH v4 net-next 1/2] ipv4: L3 hash-based multipath Peter Nørlund
2015-09-23 21:00 ` Tom Herbert
2015-09-23 21:43 ` Peter Nørlund
2015-09-23 23:12 ` Tom Herbert
2015-09-23 23:38 ` Peter Nørlund
2015-09-23 23:09 ` Peter Nørlund
2015-09-23 23:37 ` Tom Herbert
2015-09-23 21:55 ` David Miller [this message]
2015-09-23 19:49 ` [PATCH v4 net-next 2/2] ipv4: ICMP packet inspection for multipath Peter Nørlund
2015-09-23 21:01 ` Tom Herbert
2015-09-23 22:07 ` Peter Nørlund
2015-09-29 2:33 ` [PATCH v4 net-next 0/2] ipv4: Hash-based multipath routing David Miller
2015-09-29 2:55 ` David Miller
2015-09-29 11:29 ` Peter Nørlund
2015-09-29 12:38 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923.145521.609102724670024669.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pch@ordbogen.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).