From: Thomas Graf <tgraf@suug.ch>
To: Jiri Benc <jbenc@redhat.com>
Cc: netdev@vger.kernel.org, Roopa Prabhu <roopa@cumulusnetworks.com>
Subject: Re: [PATCH net 1/2] ipv4: send arp replies to the correct tunnel
Date: Wed, 23 Sep 2015 10:10:21 +0200 [thread overview]
Message-ID: <20150923081021.GC29680@pox.localdomain> (raw)
In-Reply-To: <cd7f171ada2f0933687fd2a987885aa9af7a7f9c.1442936392.git.jbenc@redhat.com>
On 09/22/15 at 06:12pm, Jiri Benc wrote:
> When using ip lwtunnels, the additional data for xmit (basically, the actual
> tunnel to use) are carried in ip_tunnel_info either in dst->lwtstate or in
> metadata dst. When replying to ARP requests, we need to send the reply to
> the same tunnel the request came from. This means we need to construct
> proper metadata dst for ARP replies.
>
> We could perform another route lookup to get a dst entry with the correct
> lwtstate. However, this won't always ensure that the outgoing tunnel is the
> same as the incoming one, and it won't work anyway for IPv4 duplicate
> address detection.
>
> The only thing to do is to "reverse" the ip_tunnel_info.
>
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
Great start, thanks!
Acked-by: Thomas Graf <tgraf@suug.ch>
next prev parent reply other threads:[~2015-09-23 8:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 16:12 [PATCH net 0/2] lwtunnel: make it really work, for IPv4 Jiri Benc
2015-09-22 16:12 ` [PATCH net 1/2] ipv4: send arp replies to the correct tunnel Jiri Benc
2015-09-23 8:10 ` Thomas Graf [this message]
2015-09-22 16:12 ` [PATCH net 2/2] lwtunnel: remove source and destination UDP port config option Jiri Benc
2015-09-23 8:12 ` Thomas Graf
2015-09-23 4:39 ` [PATCH net 0/2] lwtunnel: make it really work, for IPv4 Eric W. Biederman
2015-09-23 8:09 ` Thomas Graf
2015-09-23 12:17 ` Eric W. Biederman
2015-09-23 14:29 ` Jiri Benc
2015-09-23 17:42 ` Eric W. Biederman
2015-09-23 20:54 ` Jiri Benc
2015-09-23 21:09 ` Eric W. Biederman
2015-09-23 23:08 ` Thomas Graf
2015-09-24 5:54 ` Eric W. Biederman
2015-09-24 8:19 ` Jiri Benc
2015-09-24 8:35 ` Jiri Benc
2015-09-23 8:08 ` Thomas Graf
2015-09-24 21:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923081021.GC29680@pox.localdomain \
--to=tgraf@suug.ch \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).