From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ariel.elior@qlogic.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] bnx2x: byte swap rss_key to comply to Toeplitz specs
Date: Thu, 24 Sep 2015 14:35:13 -0700 (PDT) [thread overview]
Message-ID: <20150924.143513.1872188467000379622.davem@davemloft.net> (raw)
In-Reply-To: <1442966698.29850.107.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 22 Sep 2015 17:04:58 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> After a good amount of debugging, I found bnx2x was byte swaping
> the 40 bytes of rss_key.
>
> If we byte swap the key, then bnx2x generates hashes matching
> MSDN specs as documented in (Verifying the RSS Hash Calculation)
>
> https://msdn.microsoft.com/en-us/library/windows/hardware/ff571021%
> 28v=vs.85%29.aspx
>
> It is mostly a non issue, unless we want to mix different NIC
> in a host, and want consistent hashing among all of them, ie
> if they all use the boot time generated rss key, or if some application
> is choosing specific tuple(s) so that incoming traffic lands into known
> rx queue(s).
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks.
prev parent reply other threads:[~2015-09-24 21:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 22:21 [PATCH net-next] bnx2x: add ethtool support to read and change RSS key Eric Dumazet
2015-09-22 21:59 ` David Miller
2015-09-22 23:06 ` David Miller
2015-09-22 23:34 ` Eric Dumazet
2015-09-23 0:04 ` [PATCH net] bnx2x: byte swap rss_key to comply to Toeplitz specs Eric Dumazet
2015-09-24 21:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150924.143513.1872188467000379622.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariel.elior@qlogic.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).