* [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool
@ 2015-09-23 10:42 Ivan Mikhaylov
2015-09-23 18:05 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Ivan Mikhaylov @ 2015-09-23 10:42 UTC (permalink / raw)
To: netdev, linux-kernel, David S. Miller, Benjamin Herrenschmidt,
Ben Hutchings
Register dump out work preventing with
old ethtool + new driver and new ethtool + old driver.
---
drivers/net/ethernet/ibm/emac/core.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ibm/emac/core.h b/drivers/net/ethernet/ibm/emac/core.h
index 28df374..ac02c67 100644
--- a/drivers/net/ethernet/ibm/emac/core.h
+++ b/drivers/net/ethernet/ibm/emac/core.h
@@ -460,8 +460,8 @@ struct emac_ethtool_regs_subhdr {
u32 index;
};
-#define EMAC_ETHTOOL_REGS_VER 0
-#define EMAC4_ETHTOOL_REGS_VER 1
-#define EMAC4SYNC_ETHTOOL_REGS_VER 2
+#define EMAC_ETHTOOL_REGS_VER 3
+#define EMAC4_ETHTOOL_REGS_VER 4
+#define EMAC4SYNC_ETHTOOL_REGS_VER 5
#endif /* __IBM_NEWEMAC_CORE_H */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool
2015-09-23 10:42 [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool Ivan Mikhaylov
@ 2015-09-23 18:05 ` David Miller
2015-09-23 19:03 ` Ben Hutchings
2015-09-25 4:07 ` Ivan Mikhaylov
0 siblings, 2 replies; 6+ messages in thread
From: David Miller @ 2015-09-23 18:05 UTC (permalink / raw)
To: ivan; +Cc: netdev, linux-kernel, benh, ben
From: Ivan Mikhaylov <ivan@ru.ibm.com>
Date: Wed, 23 Sep 2015 14:42:22 +0400
> Register dump out work preventing with
> old ethtool + new driver and new ethtool + old driver.
First of all you didn't provide a proper Signoff.
Second of all, there was so much discussion about whether this does
or does not break things for various combinations of old/new ethtool
and kernel.
Therefore I want a real detailed commit message that explains why this
is all OK. After so much confusion and discussion, providing a patch
with absolutely no commit message is completely inappropriate.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool
2015-09-23 18:05 ` David Miller
@ 2015-09-23 19:03 ` Ben Hutchings
2015-09-25 4:07 ` Ivan Mikhaylov
1 sibling, 0 replies; 6+ messages in thread
From: Ben Hutchings @ 2015-09-23 19:03 UTC (permalink / raw)
To: David Miller, ivan; +Cc: netdev, linux-kernel, benh
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]
On Wed, 2015-09-23 at 11:05 -0700, David Miller wrote:
> From: Ivan Mikhaylov <ivan@ru.ibm.com>
> Date: Wed, 23 Sep 2015 14:42:22 +0400
>
> > Register dump out work preventing with
> > old ethtool + new driver and new ethtool + old driver.
>
> First of all you didn't provide a proper Signoff.
>
> Second of all, there was so much discussion about whether this does
> or does not break things for various combinations of old/new ethtool
> and kernel.
>
> Therefore I want a real detailed commit message that explains why this
> is all OK. After so much confusion and discussion, providing a patch
> with absolutely no commit message is completely inappropriate.
I would suggest something like this:
"""
The size of the MAC register dump used to be the size specified by the
reg property in the device tree. Userland has no good way of finding
out that size, and it was not specified consistently for each MAC type,
so ethtool would end up printing junk at the end of the register dump
if the device tree didn't match the size it assumed.
Using the new version numbers indicates unambiguously that the size of
the MAC register dump is dependent only on the MAC type.
Fixes: 5369c71f7ca2 ("net/ibm/emac: fix size of emac dump memory areas")
"""
Also:
Acked-by: Ben Hutchings <ben@decadent.org.uk>
Ben.
--
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool
2015-09-23 18:05 ` David Miller
2015-09-23 19:03 ` Ben Hutchings
@ 2015-09-25 4:07 ` Ivan Mikhaylov
2015-09-25 5:53 ` David Miller
1 sibling, 1 reply; 6+ messages in thread
From: Ivan Mikhaylov @ 2015-09-25 4:07 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel, benh, Ben Hutchings
On Wed, 23 Sep 2015 11:05:49 -0700 (PDT)
"David Miller" <davem@davemloft.net> wrote:
> From: Ivan Mikhaylov <ivan@ru.ibm.com>
> Date: Wed, 23 Sep 2015 14:42:22 +0400
>
> > Register dump out work preventing with
> > old ethtool + new driver and new ethtool + old driver.
>
> First of all you didn't provide a proper Signoff.
>
> Second of all, there was so much discussion about whether this does
> or does not break things for various combinations of old/new ethtool
> and kernel.
>
> Therefore I want a real detailed commit message that explains why this
> is all OK. After so much confusion and discussion, providing a patch
> with absolutely no commit message is completely inappropriate.
David, my apologies for signoff and description, I admit that is inappropriate.
Ben proposed one, is it eligible?
Need I resubmit patch with sign and detailed description?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool
2015-09-25 4:07 ` Ivan Mikhaylov
@ 2015-09-25 5:53 ` David Miller
2015-09-25 7:53 ` Ivan Mikhaylov
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2015-09-25 5:53 UTC (permalink / raw)
To: ivan; +Cc: netdev, linux-kernel, benh, ben
From: Ivan Mikhaylov <ivan@ru.ibm.com>
Date: Fri, 25 Sep 2015 08:07:52 +0400
> Ben proposed one, is it eligible?
> Need I resubmit patch with sign and detailed description?
If I genuinely need to answer that question, maybe you should sit back
for a little while and think about it yourself, ok?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool
2015-09-25 5:53 ` David Miller
@ 2015-09-25 7:53 ` Ivan Mikhaylov
0 siblings, 0 replies; 6+ messages in thread
From: Ivan Mikhaylov @ 2015-09-25 7:53 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel, benh, ben
On Thu, 24 Sep 2015 22:53:03 -0700 (PDT)
"David Miller" <davem@davemloft.net> wrote:
> From: Ivan Mikhaylov <ivan@ru.ibm.com>
> Date: Fri, 25 Sep 2015 08:07:52 +0400
>
> > Ben proposed one, is it eligible?
> > Need I resubmit patch with sign and detailed description?
>
> If I genuinely need to answer that question, maybe you should sit back
> for a little while and think about it yourself, ok?
Sorry, for those stupid questions.
David, Ben, thanks for the help.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-25 7:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-23 10:42 [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool Ivan Mikhaylov
2015-09-23 18:05 ` David Miller
2015-09-23 19:03 ` Ben Hutchings
2015-09-25 4:07 ` Ivan Mikhaylov
2015-09-25 5:53 ` David Miller
2015-09-25 7:53 ` Ivan Mikhaylov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).