netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ysato@users.sourceforge.jp
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] ne: Add h8300 support.
Date: Sun, 27 Sep 2015 12:51:30 -0700 (PDT)	[thread overview]
Message-ID: <20150927.125130.1749145249599569463.davem@davemloft.net> (raw)
In-Reply-To: <1443363556-29937-1-git-send-email-ysato@users.sourceforge.jp>

From: Yoshinori Sato <ysato@users.sourceforge.jp>
Date: Sun, 27 Sep 2015 23:19:15 +0900

> @@ -88,7 +88,7 @@ config MCF8390
>  config NE2000
>  	tristate "NE2000/NE1000 support"
>  	depends on (ISA || (Q40 && m) || M32R || MACH_TX49XX || \
> -		    ATARI_ETHERNEC)
> +		    ATARI_ETHERNEC || H8300)
...
>  
> -#if  defined(CONFIG_PLAT_MAPPI) || defined(CONFIG_PLAT_OAKS32R)
> +#if  defined(CONFIG_PLAT_MAPPI) || defined(CONFIG_PLAT_OAKS32R) || \
> +	defined(CONFIG_H8300_KANEBEBE) || defined(CONFIG_H8300_AE3069)

It makes no sense to test different config symbols for these two
things.

Either both should use "H8300" or both should use
"H8300_KANEBEBE || H8300_AE3069".

  parent reply	other threads:[~2015-09-27 19:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-27 14:19 [PATCH 1/2] ne: Add h8300 support Yoshinori Sato
2015-09-27 14:19 ` [PATCH 2/2] ne: DeviceTree support Yoshinori Sato
2015-09-27 19:51 ` David Miller [this message]
2015-10-02  6:04   ` [PATCH 1/2] ne: Add h8300 support Yoshinori Sato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150927.125130.1749145249599569463.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).