From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Subject: Fw: [Bug 105091] New: ICMP unreachable is not sent when receiving GRE packets on device that has no tunnel interface
Date: Sun, 27 Sep 2015 18:06:14 -0700 [thread overview]
Message-ID: <20150927180614.52ac9154@urahara> (raw)
Begin forwarded message:
Date: Sun, 27 Sep 2015 22:42:34 +0000
From: "bugzilla-daemon@bugzilla.kernel.org" <bugzilla-daemon@bugzilla.kernel.org>
To: "shemminger@linux-foundation.org" <shemminger@linux-foundation.org>
Subject: [Bug 105091] New: ICMP unreachable is not sent when receiving GRE packets on device that has no tunnel interface
https://bugzilla.kernel.org/show_bug.cgi?id=105091
Bug ID: 105091
Summary: ICMP unreachable is not sent when receiving GRE
packets on device that has no tunnel interface
Product: Networking
Version: 2.5
Kernel Version: 4.2
Hardware: All
OS: Linux
Tree: Mainline
Status: NEW
Severity: low
Priority: P1
Component: IPV4
Assignee: shemminger@linux-foundation.org
Reporter: isaac.lee@alliedtelesis.co.nz
Regression: No
Created attachment 188691
--> https://bugzilla.kernel.org/attachment.cgi?id=188691&action=edit
fix patch
This used to work in version 3.9. In file ip_gre.c, when a GRE packet is
received and tunnel lookup returned NULL (ie, no such interface), ipgre_rcv()
calls icmp_send() to respond with port unreachable message.
In the latest version, gre_demux.c tries to do the same thing in
gre_cisco_rcv(), but icmp_send fails because skb dst entry has been dropped
(during parse_gre_header() -> iptunnel_pull_header() -> skb_dst_drop(skb);)
prior to calling icmp_send, causing icmp_send to return early due to rt is
NULL.
A fix patch is attached.
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2015-09-28 1:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150927180614.52ac9154@urahara \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).