From: David Miller <davem@davemloft.net>
To: bst@pengutronix.de
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org, trivial@kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] net ipv4 ipconfig: use preferred log methods
Date: Mon, 28 Sep 2015 22:24:09 -0700 (PDT) [thread overview]
Message-ID: <20150928.222409.1641594777817922710.davem@davemloft.net> (raw)
In-Reply-To: <1443175110-23498-1-git-send-email-bst@pengutronix.de>
From: Bastian Stender <bst@pengutronix.de>
Date: Fri, 25 Sep 2015 11:58:30 +0200
> @@ -69,7 +69,7 @@
> #undef IPCONFIG_DEBUG
>
> #ifdef IPCONFIG_DEBUG
> -#define DBG(x) printk x
> +#define DBG(x) pr_debug(x)
> #else
> #define DBG(x) do { } while(0)
> #endif
I agree with Stephen, just get rid of this and use pr_debug()
unconditionally.
next prev parent reply other threads:[~2015-09-29 5:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 9:58 [PATCH] net ipv4 ipconfig: use preferred log methods Bastian Stender
2015-09-28 5:37 ` Stephen Hemminger
2015-09-29 5:24 ` David Miller [this message]
2015-09-30 9:20 ` [PATCH] net ipv4: " Bastian Stender
2015-09-30 9:31 ` kbuild test robot
2015-09-30 9:31 ` kbuild test robot
2015-09-30 11:07 ` Bastian Stender
2015-09-30 15:00 ` Bastian Stender
2015-10-01 7:55 ` Uwe Kleine-König
2015-11-13 10:40 ` [PATCH v2] " Bastian Stender
2015-11-13 10:40 ` [PATCH] " Bastian Stender
2015-11-18 18:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928.222409.1641594777817922710.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bst@pengutronix.de \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kernel@pengutronix.de \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).