* [PATCH net-next] lan78xx: Return 0 when lan78xx_suspend() has no error.
@ 2015-09-25 21:13 Woojung.Huh
2015-09-29 5:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Woojung.Huh @ 2015-09-25 21:13 UTC (permalink / raw)
To: davem; +Cc: netdev
lan78xx_suspend() may return non-zero from lan78xx_write_reg() in some scenario.
Fix to return 0 when lan78xx_suspend() has no error.
Signed-off-by: Woojung Huh <woojung.huh@microchip.com>
---
drivers/net/usb/lan78xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index d2a5f3f..226668e 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -3204,7 +3204,6 @@ int lan78xx_suspend(struct usb_interface *intf, pm_message_t message)
int ret;
int event;
- ret = 0;
event = message.event;
if (!dev->suspend_count++) {
@@ -3286,6 +3285,7 @@ int lan78xx_suspend(struct usb_interface *intf, pm_message_t message)
}
}
+ ret = 0;
out:
return ret;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] lan78xx: Return 0 when lan78xx_suspend() has no error.
2015-09-25 21:13 [PATCH net-next] lan78xx: Return 0 when lan78xx_suspend() has no error Woojung.Huh
@ 2015-09-29 5:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-09-29 5:29 UTC (permalink / raw)
To: Woojung.Huh; +Cc: netdev
From: <Woojung.Huh@microchip.com>
Date: Fri, 25 Sep 2015 21:13:48 +0000
> lan78xx_suspend() may return non-zero from lan78xx_write_reg() in some scenario.
> Fix to return 0 when lan78xx_suspend() has no error.
>
> Signed-off-by: Woojung Huh <woojung.huh@microchip.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-29 5:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-25 21:13 [PATCH net-next] lan78xx: Return 0 when lan78xx_suspend() has no error Woojung.Huh
2015-09-29 5:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).