netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Tom Herbert <tom@herbertland.com>
Cc: Florian Westphal <fw@strlen.de>,
	David Miller <davem@davemloft.net>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH net-next 0/4] ila: Use NF_INET_PRE_ROUTING nfhook
Date: Tue, 29 Sep 2015 01:00:10 +0200	[thread overview]
Message-ID: <20150928230010.GB19923@breakpoint.cc> (raw)
In-Reply-To: <CALx6S35gFbcFjCWEQsDY_DzBOrr0i7+3fdBWiF4rLmcz9HJRBg@mail.gmail.com>

Tom Herbert <tom@herbertland.com> wrote:
> RFC6296 doesn't work because it allows an invalid checksum to be sent
> on wire relative to the addresses used on the wire. That means we
> would lose CHECKSUM_UNNECESSARY for ILA which is way too big of a
> performance hit.

Not following.  I did not say you should use NPT instead of ILA.

[..]
> In any case, I did at one point create some netfilter targets for ILA
> to do the translation correctly updating the checksum. While this
> provided the required functionality, I couldn't get sufficient
> performance. A specialized fixed length lookup table gets most of the
> performance needed for ILA.

I'm not following at all.

Could you explain why you can't just 'relocate' your proposed
implementation to netfilter/ipv6?

F.e. I see no reason why you could not use a lookup table in a netfilter
target (or nft expression, for that matter) ... ?

Thanks,
Florian

  reply	other threads:[~2015-09-28 23:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24 16:30 [PATCH net-next 0/4] ila: Use NF_INET_PRE_ROUTING nfhook Tom Herbert
2015-09-24 16:30 ` [PATCH net-next 1/4] rhashtable: add function to replace an element Tom Herbert
2015-09-24 16:30 ` [PATCH net-next 2/4] netlink: add a start callback for starting a netlink dump Tom Herbert
2015-09-24 16:30 ` [PATCH net-next 3/4] ila: Create net/ipv6/ila directory Tom Herbert
2015-09-24 16:30 ` [PATCH net-next 4/4] ila: Add support for netfilter NF_INET_PRE_ROUTING hook Tom Herbert
2015-09-27  6:15 ` [PATCH net-next 0/4] ila: Use NF_INET_PRE_ROUTING nfhook David Miller
2015-09-27  8:10   ` Florian Westphal
2015-09-28 22:27     ` Tom Herbert
2015-09-28 23:00       ` Florian Westphal [this message]
2015-09-29 17:17         ` Tom Herbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150928230010.GB19923@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=davem@davemloft.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).