From: David Miller <davem@davemloft.net>
To: pshelar@nicira.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] skbuff: Fix skb checksum partial check.
Date: Tue, 29 Sep 2015 16:49:32 -0700 (PDT) [thread overview]
Message-ID: <20150929.164932.1619659673911486443.davem@davemloft.net> (raw)
In-Reply-To: <1443486265-2246-1-git-send-email-pshelar@nicira.com>
From: Pravin B Shelar <pshelar@nicira.com>
Date: Mon, 28 Sep 2015 17:24:25 -0700
> Earlier patch 6ae459bda tried to detect void ckecksum partial
> skb by comparing pull length to checksum offset. But it does
> not work for all cases since checksum-offset depends on
> updates to skb->data.
>
> Following patch fixes it by validating checksum start offset
> after skb-data pointer is updated. Negative value of checksum
> offset start means there is no need to checksum.
>
> Fixes: 6ae459bda ("skbuff: Fix skb checksum flag on skb pull")
> Reported-by: Andrew Vagin <avagin@odin.com>
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
> ---
> This and 6ae459bda patches needs to be backported to stable.
Applied and both queued up for -stable, thanks.
prev parent reply other threads:[~2015-09-29 23:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 0:24 [PATCH net] skbuff: Fix skb checksum partial check Pravin B Shelar
2015-09-29 0:46 ` Tom Herbert
2015-09-29 3:13 ` Pravin Shelar
2015-09-29 23:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929.164932.1619659673911486443.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).