* [PATCH net-next] dsa: mv88e6xxx: Fix unsigned/signed issue
@ 2015-09-28 23:53 Andrew Lunn
2015-09-30 4:13 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Lunn @ 2015-09-28 23:53 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Dan Carpenter, Andrew Lunn
commit dea870242a9c ("dsa: mv88e6xxx: Allow speed/duplex of port to be
configured") leads to the following static checker warning:
drivers/net/dsa/mv88e6xxx.c:585 mv88e6xxx_adjust_link()
warn: unsigned 'ret' is never less than zero.
drivers/net/dsa/mv88e6xxx.c
573 void mv88e6xxx_adjust_link(struct dsa_switch *ds, int port,
574 struct phy_device *phydev)
575 {
576 struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
577 u32 ret, reg;
578
579 if (!phy_is_pseudo_fixed_link(phydev))
580 return;
581
582 mutex_lock(&ps->smi_mutex);
583
584 ret = _mv88e6xxx_reg_read(ds, REG_PORT(port), PORT_PCS_CTRL);
585 if (ret < 0)
Make ret an int, which is the return type for _mv88e6xxx_reg_read()
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index 30227ca2d5db..05c0938da8c3 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -574,7 +574,8 @@ void mv88e6xxx_adjust_link(struct dsa_switch *ds, int port,
struct phy_device *phydev)
{
struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
- u32 ret, reg;
+ u32 reg;
+ int ret;
if (!phy_is_pseudo_fixed_link(phydev))
return;
--
2.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] dsa: mv88e6xxx: Fix unsigned/signed issue
2015-09-28 23:53 [PATCH net-next] dsa: mv88e6xxx: Fix unsigned/signed issue Andrew Lunn
@ 2015-09-30 4:13 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-09-30 4:13 UTC (permalink / raw)
To: andrew; +Cc: netdev, dan.carpenter
From: Andrew Lunn <andrew@lunn.ch>
Date: Tue, 29 Sep 2015 01:53:48 +0200
> commit dea870242a9c ("dsa: mv88e6xxx: Allow speed/duplex of port to be
> configured") leads to the following static checker warning:
>
> drivers/net/dsa/mv88e6xxx.c:585 mv88e6xxx_adjust_link()
> warn: unsigned 'ret' is never less than zero.
>
> drivers/net/dsa/mv88e6xxx.c
> 573 void mv88e6xxx_adjust_link(struct dsa_switch *ds, int port,
> 574 struct phy_device *phydev)
> 575 {
> 576 struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
> 577 u32 ret, reg;
> 578
> 579 if (!phy_is_pseudo_fixed_link(phydev))
> 580 return;
> 581
> 582 mutex_lock(&ps->smi_mutex);
> 583
> 584 ret = _mv88e6xxx_reg_read(ds, REG_PORT(port), PORT_PCS_CTRL);
> 585 if (ret < 0)
>
> Make ret an int, which is the return type for _mv88e6xxx_reg_read()
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-30 4:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-28 23:53 [PATCH net-next] dsa: mv88e6xxx: Fix unsigned/signed issue Andrew Lunn
2015-09-30 4:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).