[PATCH] testptp: Silence compiler warnings on ppc64

[PATCH] testptp: Silence compiler warnings on ppc64

[Thomas Huth]

When compiling Documentation/ptp/testptp.c the following compiler
warnings are printed out:

Documentation/ptp/testptp.c: In function ‘main’:
Documentation/ptp/testptp.c:367:11: warning: format ‘%lld’ expects argument
    of type ‘long long int’, but argument 3 has type ‘__s64’ [-Wformat=]
           event.t.sec, event.t.nsec);
           ^
Documentation/ptp/testptp.c:505:5: warning: format ‘%lld’ expects argument
    of type ‘long long int’, but argument 2 has type ‘__s64’ [-Wformat=]
     (pct+2*i)->sec, (pct+2*i)->nsec);
     ^
Documentation/ptp/testptp.c:507:5: warning: format ‘%lld’ expects argument
    of type ‘long long int’, but argument 2 has type ‘__s64’ [-Wformat=]
     (pct+2*i+1)->sec, (pct+2*i+1)->nsec);
     ^
Documentation/ptp/testptp.c:509:5: warning: format ‘%lld’ expects argument
    of type ‘long long int’, but argument 2 has type ‘__s64’ [-Wformat=]
     (pct+2*i+2)->sec, (pct+2*i+2)->nsec);

This happens because __s64 is by default defined as "long" on ppc64,
not as "long long". However, to fix these warnings, it's possible to
define the __SANE_USERSPACE_TYPES__ so that __s64 gets defined to
"long long" on ppc64, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 Documentation/ptp/testptp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/ptp/testptp.c b/Documentation/ptp/testptp.c
index 2bc8abc..6c6247a 100644
--- a/Documentation/ptp/testptp.c
+++ b/Documentation/ptp/testptp.c
@@ -18,6 +18,7 @@
  *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 #define _GNU_SOURCE
+#define __SANE_USERSPACE_TYPES__        /* For PPC64, to get LL64 types */
 #include <errno.h>
 #include <fcntl.h>
 #include <inttypes.h>
-- 
1.8.3.1

Re: [PATCH] testptp: Silence compiler warnings on ppc64

[Richard Cochran]

On Tue, Sep 29, 2015 at 05:45:28PM +0200, Thomas Huth wrote:
> This happens because __s64 is by default defined as "long" on ppc64,
> not as "long long". However, to fix these warnings, it's possible to
> define the __SANE_USERSPACE_TYPES__ so that __s64 gets defined to
> "long long" on ppc64, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Acked-by: Richard Cochran <richardcochran@gmail.com>

Re: [PATCH] testptp: Silence compiler warnings on ppc64

[David Miller]

From: Thomas Huth <thuth@redhat.com>
Date: Tue, 29 Sep 2015 17:45:28 +0200

> When compiling Documentation/ptp/testptp.c the following compiler
> warnings are printed out:
 ...
> This happens because __s64 is by default defined as "long" on ppc64,
> not as "long long". However, to fix these warnings, it's possible to
> define the __SANE_USERSPACE_TYPES__ so that __s64 gets defined to
> "long long" on ppc64, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Applied, thanks.