From: Jiri Benc <jbenc@redhat.com>
To: Jesse Gross <jesse@nicira.com>
Cc: netdev <netdev@vger.kernel.org>,
"dev@openvswitch.org" <dev@openvswitch.org>
Subject: Re: [ovs-dev] [PATCH net-next 1/2] openvswitch: add tunnel protocol to sw_flow_key
Date: Wed, 30 Sep 2015 09:14:09 +0200 [thread overview]
Message-ID: <20150930091409.33d4b7ae@griffin> (raw)
In-Reply-To: <CAEP_g=_5EhyYeSNvitYSbNX9G52Kt=R6ruNz4V0uJK8sxPyYWQ@mail.gmail.com>
On Tue, 29 Sep 2015 19:08:44 -0700, Jesse Gross wrote:
> On Tue, Sep 29, 2015 at 10:52 AM, Jiri Benc <jbenc@redhat.com> wrote:
> > diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
> > index 5c030a4d7338..03ba070c3256 100644
> > --- a/net/openvswitch/flow_netlink.c
> > +++ b/net/openvswitch/flow_netlink.c
> > @@ -643,6 +643,7 @@ static int ipv4_tun_from_nlattr(const struct nlattr *attr,
> > }
> >
> > SW_FLOW_KEY_PUT(match, tun_key.tun_flags, tun_flags, is_mask);
> > + SW_FLOW_KEY_PUT(match, tun_proto, AF_INET, is_mask);
>
> I don't think this is right in the case of the mask. It will cause the
> the mask to be the value AF_INET - instead you want to set the mask to
> be 0xff.
I think you're right, this is a special case. I'll fix it.
Thanks,
Jiri
--
Jiri Benc
next prev parent reply other threads:[~2015-09-30 7:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 17:52 [PATCH net-next 0/2] openvswitch: add IPv6 tunneling support Jiri Benc
2015-09-29 17:52 ` [PATCH net-next 1/2] openvswitch: add tunnel protocol to sw_flow_key Jiri Benc
2015-09-29 20:41 ` Pravin Shelar
2015-09-30 7:09 ` Jiri Benc
2015-09-30 20:13 ` Pravin Shelar
2015-09-30 20:25 ` [ovs-dev] " Jesse Gross
2015-09-30 20:52 ` Jiri Benc
2015-09-30 2:08 ` Jesse Gross
2015-09-30 7:14 ` Jiri Benc [this message]
2015-09-29 17:52 ` [PATCH net-next 2/2] openvswitch: netlink attributes for IPv6 tunneling Jiri Benc
2015-09-30 3:05 ` Jesse Gross
2015-09-30 7:28 ` Jiri Benc
2015-09-30 20:18 ` Jesse Gross
2015-09-30 21:05 ` Jiri Benc
2015-09-30 21:29 ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930091409.33d4b7ae@griffin \
--to=jbenc@redhat.com \
--cc=dev@openvswitch.org \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).