From: kbuild test robot <lkp@intel.com>
To: Yuval Mintz <Yuval.Mintz@qlogic.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org,
Ariel.Elior@qlogic.com, Yuval.Mintz@qlogic.com
Subject: [PATCH] qed: fix simple_return.cocci warnings
Date: Wed, 30 Sep 2015 21:33:28 +0800 [thread overview]
Message-ID: <20150930133328.GA193090@lkp-ib03> (raw)
In-Reply-To: <1443618217-18069-2-git-send-email-Yuval.Mintz@qlogic.com>
drivers/net/ethernet/qlogic/qed/qed_spq.c:673:1-3: WARNING: end returns can be simpified
Simplify a trivial if-return sequence. Possibly combine with a
preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci
CC: Yuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
qed_spq.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--- a/drivers/net/ethernet/qlogic/qed/qed_spq.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_spq.c
@@ -670,13 +670,9 @@ static int qed_spq_pend_post(struct qed_
qed_spq_add_entry(p_hwfn, p_ent, p_ent->priority);
}
- rc = qed_spq_post_list(p_hwfn,
+ return qed_spq_post_list(p_hwfn,
&p_spq->pending,
SPQ_HIGH_PRI_RESERVE_DEFAULT);
- if (rc)
- return rc;
-
- return 0;
}
int qed_spq_post(struct qed_hwfn *p_hwfn,
next prev parent reply other threads:[~2015-09-30 13:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 13:03 [RFC v3 net-next 00/10] Add new drivers: qed & qede Yuval Mintz
2015-09-30 13:03 ` [RFC v3 net-next 01/10] qed: Add module with basic common support Yuval Mintz
2015-09-30 13:33 ` [PATCH] qed: fix kzalloc-simple.cocci warnings kbuild test robot
2015-09-30 13:33 ` kbuild test robot [this message]
2015-09-30 13:50 ` [RFC v3 net-next 01/10] qed: Add module with basic common support kbuild test robot
2015-09-30 13:54 ` kbuild test robot
2015-09-30 13:03 ` [RFC v3 net-next 02/10] qed: Add basic L2 interface Yuval Mintz
2015-09-30 13:03 ` [RFC v3 net-next 03/10] qede: Add basic Network driver Yuval Mintz
2015-09-30 13:03 ` [RFC v3 net-next 04/10] qed: Add slowpath L2 support Yuval Mintz
2015-09-30 13:40 ` kbuild test robot
2015-09-30 13:59 ` kbuild test robot
2015-09-30 13:03 ` [RFC v3 net-next 05/10] qede: Add basic network device support Yuval Mintz
2015-09-30 13:48 ` [PATCH] qede: fix simple_return.cocci warnings kbuild test robot
2015-09-30 13:48 ` [RFC v3 net-next 05/10] qede: Add basic network device support kbuild test robot
2015-09-30 13:03 ` [RFC v3 net-next 06/10] qede: classification configuration Yuval Mintz
2015-09-30 13:03 ` [RFC v3 net-next 07/10] qed: Add link support Yuval Mintz
2015-09-30 14:08 ` kbuild test robot
2015-09-30 13:03 ` [RFC v3 net-next 08/10] qede: Add support for link Yuval Mintz
2015-09-30 13:03 ` [RFC v3 net-next 09/10] qed: Add statistics support Yuval Mintz
2015-09-30 14:18 ` kbuild test robot
2015-09-30 14:23 ` kbuild test robot
2015-09-30 13:03 ` [RFC v3 net-next 10/10] qede: Add basic ethtool support Yuval Mintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930133328.GA193090@lkp-ib03 \
--to=lkp@intel.com \
--cc=Ariel.Elior@qlogic.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).