From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] qede: fix simple_return.cocci warnings Date: Wed, 30 Sep 2015 21:48:15 +0800 Message-ID: <20150930134815.GA102781@lkp-ib03> References: <201509302150.a1QzjRP8%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, netdev@vger.kernel.org, Ariel.Elior@qlogic.com, Yuval.Mintz@qlogic.com, Sudarsana Kalluru To: Yuval Mintz Return-path: Received: from mga14.intel.com ([192.55.52.115]:42682 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265AbbI3Ntx (ORCPT ); Wed, 30 Sep 2015 09:49:53 -0400 Content-Disposition: inline In-Reply-To: <1443618217-18069-6-git-send-email-Yuval.Mintz@qlogic.com> Sender: netdev-owner@vger.kernel.org List-ID: drivers/net/ethernet/qlogic/qede/qede_main.c:2141:1-3: WARNING: end returns can be simpified and declaration on line 2134 can be dropped Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Sudarsana Kalluru Signed-off-by: Fengguang Wu --- qede_main.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) --- a/drivers/net/ethernet/qlogic/qede/qede_main.c +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c @@ -2131,18 +2131,13 @@ err0: /* called with rtnl_lock */ static int qede_open(struct net_device *ndev) { - int rc; struct qede_dev *edev = netdev_priv(ndev); netif_carrier_off(ndev); edev->ops->common->set_power_state(edev->cdev, PCI_D0); - rc = qede_load(edev, QEDE_LOAD_NORMAL); - if (rc) - return rc; - - return 0; + return qede_load(edev, QEDE_LOAD_NORMAL); } static int qede_close(struct net_device *ndev)