netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: santosh shilimkar <santosh.shilimkar@oracle.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	davem@davemloft.net, rds-devel@oss.oracle.com,
	ajaykumar.hotchandani@oracle.com, igor.maximov@oracle.com
Subject: Re: [PATCH net-next 1/3] net/rds: Use a single TCP socket for both send and receive.
Date: Wed, 30 Sep 2015 12:09:08 -0400	[thread overview]
Message-ID: <20150930160908.GC8111@oracle.com> (raw)
In-Reply-To: <560C04AA.4050201@oracle.com>

On (09/30/15 08:50), santosh shilimkar wrote:
> >  	rs_tcp = (struct rds_tcp_connection *)conn->c_transport_data;
> >-	WARN_ON(!rs_tcp || rs_tcp->t_sock);
> >+	if (rs_tcp->t_sock && inet->inet_saddr < inet->inet_daddr) {
> >+		struct sock *nsk = new_sock->sk;
> >
> Any reason you dropped the WARN_ON. Note that till we got commit
> 74e98eb0 (" RDS: verify the underlying transport exists before creating
> a connection") merged, we had an issue. That guards it now.

That was done deliberately. Now that we have only one tcp socket,
we can run into an rds_tcp_connection for an outgoing connection
that we initiated, thus rs_tcp->t_sock can be non-null - which is
why a new check is added in the newly added line in the patch.

  parent reply	other threads:[~2015-09-30 16:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 13:45 [PATCH net-next 0/3] RDS: RDS-TCP perf enhancements Sowmini Varadhan
2015-09-30 13:45 ` [PATCH net-next 1/3] net/rds: Use a single TCP socket for both send and receive Sowmini Varadhan
2015-09-30 14:45   ` kbuild test robot
2015-09-30 15:50   ` santosh shilimkar
2015-09-30 15:58     ` Sowmini Varadhan
2015-09-30 16:04       ` santosh shilimkar
2015-09-30 16:09     ` Sowmini Varadhan [this message]
2015-09-30 16:13       ` santosh shilimkar
2015-09-30 13:45 ` [PATCH net-next 2/3] RDS-TCP: Do not bloat sndbuf/rcvbuf in rds_tcp_tune Sowmini Varadhan
2015-09-30 15:54   ` santosh shilimkar
2015-09-30 13:45 ` [PATCH net-next 3/3] RDS-TCP: Set up MSG_MORE and MSG_SENDPAGE_NOTLAST as appropriate in rds_tcp_xmit Sowmini Varadhan
2015-09-30 14:53   ` Sergei Shtylyov
2015-09-30 15:56   ` santosh shilimkar
2015-09-30 16:00     ` Sowmini Varadhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150930160908.GC8111@oracle.com \
    --to=sowmini.varadhan@oracle.com \
    --cc=ajaykumar.hotchandani@oracle.com \
    --cc=davem@davemloft.net \
    --cc=igor.maximov@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rds-devel@oss.oracle.com \
    --cc=santosh.shilimkar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).