From: Jiri Pirko <jiri@mellanox.com>
To: Scott Feldman <sfeldma@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>, Netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Ido Schimmel <idosch@mellanox.com>, <eladr@mellanox.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
"andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [patch net-next] switchdev: bring back switchdev_obj and use it as a generic object param
Date: Thu, 1 Oct 2015 08:04:39 +0200 [thread overview]
Message-ID: <20151001060439.GA2156@nanopsycho.orion> (raw)
In-Reply-To: <CAE4R7bDOAvR4WKJ5-_Tpx_MOgA=9Eo=rDASUD3pTRitAo1mjMA@mail.gmail.com>
Thu, Oct 01, 2015 at 05:44:55AM CEST, sfeldma@gmail.com wrote:
>On Wed, Sep 30, 2015 at 9:00 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> Replace "void *obj" with a generic structure. Introduce couple of
>> helpers along that.
>>
>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>
>Looks good to me, except for the macro/enum collision Vivien pointed
>out. Vivien's suggestion to use SWITCHDEV_OBJ_ID_xxx for ID enums
>would work.
ok
>
>Actually, id should be moved back into switchdev_obj, otherwise that
>info is lost in dump callbacks. Could have a common callback that
>switches on id, for id specific work. I'll submit a patch to move id
>back into obj if Jiri doesn't add it to this one.
I was thinking about it as well and it makes sense. I'll add it.
prev parent reply other threads:[~2015-10-01 6:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 16:00 [patch net-next] switchdev: bring back switchdev_obj and use it as a generic object param Jiri Pirko
2015-09-30 18:00 ` Vivien Didelot
2015-10-01 6:24 ` Jiri Pirko
2015-10-01 3:44 ` Scott Feldman
2015-10-01 6:04 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001060439.GA2156@nanopsycho.orion \
--to=jiri@mellanox.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).