From: Florian Westphal <fw@strlen.de>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>, fw@strlen.de
Subject: Re: [PATCH net] netfilter: remove the nh_scope test in rpfilter_lookup_reverse of ipt_rpfilter
Date: Sun, 4 Oct 2015 23:48:02 +0200 [thread overview]
Message-ID: <20151004214802.GB6032@breakpoint.cc> (raw)
In-Reply-To: <c7a265fa26e9558115abb58869caa6012924355b.1443970560.git.lucien.xin@gmail.com>
Xin Long <lucien.xin@gmail.com> wrote:
> it seems the test is bogus and can be removed to fix this issue.
>
> if (dev_match || flags & XT_RPFILTER_LOOSE)
> return FIB_RES_NH(res).nh_scope <= RT_SCOPE_HOST;
>
> ipv6 does not have this issue.
netfilter patches should be sent to netfilter-devel@vger.kernel.org
> #endif
> - if (dev_match || flags & XT_RPFILTER_LOOSE)
> - return FIB_RES_NH(res).nh_scope <= RT_SCOPE_HOST;
> return dev_match;
> }
This breaks --loose option, no?
Thats why I earlier suggested to change this to
> - if (dev_match || flags & XT_RPFILTER_LOOSE)
> - return FIB_RES_NH(res).nh_scope <= RT_SCOPE_HOST;
+ return dev_match || flags & XT_RPFILTER_LOOSE;
prev parent reply other threads:[~2015-10-04 21:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 14:56 [PATCH net] netfilter: remove the nh_scope test in rpfilter_lookup_reverse of ipt_rpfilter Xin Long
2015-10-04 21:48 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151004214802.GB6032@breakpoint.cc \
--to=fw@strlen.de \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).