netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: g.nault@alphalink.fr
Cc: netdev@vger.kernel.org, paulus@samba.org, core@irc.lg.ua,
	nuclearcat@nuclearcat.com
Subject: Re: [PATCH net] ppp: don't override sk->sk_state in pppoe_flush_dev()
Date: Mon, 05 Oct 2015 03:05:00 -0700 (PDT)	[thread overview]
Message-ID: <20151005.030500.1845779775642013934.davem@davemloft.net> (raw)
In-Reply-To: <b7fbf103cd589741e3938550e7cf0f3684d8951c.1443605079.git.g.nault@alphalink.fr>

From: Guillaume Nault <g.nault@alphalink.fr>
Date: Wed, 30 Sep 2015 11:45:33 +0200

> Since commit 2b018d57ff18 ("pppoe: drop PPPOX_ZOMBIEs in pppoe_release"),
> pppoe_release() calls dev_put(po->pppoe_dev) if sk is in the
> PPPOX_ZOMBIE state. But pppoe_flush_dev() can set sk->sk_state to
> PPPOX_ZOMBIE _and_ reset po->pppoe_dev to NULL. This leads to the
> following oops:
 ...
> pppoe_flush_dev() has no reason to override sk->sk_state with
> PPPOX_ZOMBIE. pppox_unbind_sock() already sets sk->sk_state to
> PPPOX_DEAD, which is the correct state given that sk is unbound and
> po->pppoe_dev is NULL.
> 
> Fixes: 2b018d57ff18 ("pppoe: drop PPPOX_ZOMBIEs in pppoe_release")
> Tested-by: Oleksii Berezhniak <core@irc.lg.ua>
> Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>

Applied and queued up for -stable, thanks.

      parent reply	other threads:[~2015-10-05  9:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30  9:45 [PATCH net] ppp: don't override sk->sk_state in pppoe_flush_dev() Guillaume Nault
2015-10-02  8:01 ` Denys Fedoryshchenko
2015-10-02 17:54   ` Guillaume Nault
2015-10-04 16:08     ` Denys Fedoryshchenko
2015-10-05  4:08       ` Matt Bennett
2015-10-05 12:24         ` Guillaume Nault
2015-10-06  0:26           ` Matt Bennett
2015-10-06  4:46             ` Matt Bennett
2015-10-06  9:46               ` Guillaume Nault
2015-10-06 21:12                 ` Matt Bennett
2015-10-07 10:32                   ` Guillaume Nault
2015-10-06  8:50             ` Guillaume Nault
2015-10-05 12:08       ` Guillaume Nault
2015-10-07 12:12         ` Guillaume Nault
2015-10-13  2:13           ` Denys Fedoryshchenko
2015-10-13  7:24             ` Guillaume Nault
2015-10-22  0:14             ` Matt Bennett
2015-10-22  0:53               ` Denys Fedoryshchenko
2015-10-22 14:49                 ` Guillaume Nault
2015-10-05 10:05 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151005.030500.1845779775642013934.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=core@irc.lg.ua \
    --cc=g.nault@alphalink.fr \
    --cc=netdev@vger.kernel.org \
    --cc=nuclearcat@nuclearcat.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).