netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] tcp: restore fastopen operations
@ 2015-09-30 13:18 Eric Dumazet
  2015-10-05 10:19 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2015-09-30 13:18 UTC (permalink / raw)
  To: David Miller; +Cc: netdev

From: Eric Dumazet <edumazet@google.com>

I accidentally cleared fastopenq.max_qlen in reqsk_queue_alloc()
while max_qlen can be set before listen() is called,
using TCP_FASTOPEN socket option for example.

Fixes: 0536fcc039a8 ("tcp: prepare fastopen code for upcoming listener changes")
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/core/request_sock.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/net/core/request_sock.c b/net/core/request_sock.c
index e22cfa4ed25f817dbc4871e1618349b2..ef031d959d80f2b45e4077680026a0f8 100644
--- a/net/core/request_sock.c
+++ b/net/core/request_sock.c
@@ -64,7 +64,6 @@ int reqsk_queue_alloc(struct request_sock_queue *queue,
 	queue->fastopenq.rskq_rst_head = NULL;
 	queue->fastopenq.rskq_rst_tail = NULL;
 	queue->fastopenq.qlen = 0;
-	queue->fastopenq.max_qlen = 0;
 
 	queue->rskq_accept_head = NULL;
 	lopt->nr_table_entries = nr_table_entries;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] tcp: restore fastopen operations
  2015-09-30 13:18 [PATCH net-next] tcp: restore fastopen operations Eric Dumazet
@ 2015-10-05 10:19 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-10-05 10:19 UTC (permalink / raw)
  To: eric.dumazet; +Cc: netdev

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 30 Sep 2015 06:18:23 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> I accidentally cleared fastopenq.max_qlen in reqsk_queue_alloc()
> while max_qlen can be set before listen() is called,
> using TCP_FASTOPEN socket option for example.
> 
> Fixes: 0536fcc039a8 ("tcp: prepare fastopen code for upcoming listener changes")
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied, thanks Eric.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-05 10:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-30 13:18 [PATCH net-next] tcp: restore fastopen operations Eric Dumazet
2015-10-05 10:19 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).