From: David Miller <davem@davemloft.net>
To: jon@ringle.org
Cc: broonie@kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
jringle@gridpoint.com
Subject: Re: [PATCH net-next v2 2/2] net: Microchip encx24j600 driver
Date: Mon, 05 Oct 2015 04:00:42 -0700 (PDT) [thread overview]
Message-ID: <20151005.040042.705688813405698539.davem@davemloft.net> (raw)
In-Reply-To: <20151005.035455.1570277826736853837.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Mon, 05 Oct 2015 03:54:55 -0700 (PDT)
> From: jon@ringle.org
> Date: Thu, 1 Oct 2015 07:43:21 -0400
>
>> From: Jon Ringle <jringle@gridpoint.com>
>>
>> This ethernet driver supports the Micorchip enc424j600/626j600 Ethernet
>> controller over a SPI bus interface. This driver makes use of the regmap API to
>> optimize access to registers by caching registers where possible.
>>
>> Datasheet:
>> http://ww1.microchip.com/downloads/en/DeviceDoc/39935b.pdf
>>
>> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
>
> Applied.
Actually, I had to revert both patches. Please look at the compiler
warnings your code generates:
drivers/mfd/wm5110-tables.c: In function ‘wm5110_patch’:
drivers/mfd/wm5110-tables.c:281:11: warning: passing argument 2 of ‘regmap_register_patch’ from incompatible pointer type [enabled by default]
In file included from include/linux/mfd/arizona/core.h:17:0,
from drivers/mfd/wm5110-tables.c:15:
include/linux/regmap.h:727:5: note: expected ‘const struct reg_sequence *’ but argument is of type ‘const struct reg_default *’
drivers/mfd/wm8998-tables.c: In function ‘wm8998_patch’:
drivers/mfd/wm8998-tables.c:50:10: warning: passing argument 2 of ‘regmap_register_patch’ from incompatible pointer type [enabled by default]
In file included from include/linux/mfd/arizona/core.h:17:0,
from drivers/mfd/wm8998-tables.c:15:
include/linux/regmap.h:727:5: note: expected ‘const struct reg_sequence *’ but argument is of type ‘const struct reg_default *’
next prev parent reply other threads:[~2015-10-05 11:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 11:43 [PATCH net-next v2 1/2] regmap: Allow installing custom reg_update_bits function jon
2015-10-01 11:43 ` [PATCH net-next v2 2/2] net: Microchip encx24j600 driver jon
2015-10-01 12:26 ` [RFC PATCH] net: encx24j600_exit() can be static kbuild test robot
2015-10-05 10:54 ` [PATCH net-next v2 2/2] net: Microchip encx24j600 driver David Miller
2015-10-05 11:00 ` David Miller [this message]
2015-10-05 11:01 ` David Miller
2015-10-05 10:54 ` [PATCH net-next v2 1/2] regmap: Allow installing custom reg_update_bits function David Miller
2015-10-05 11:57 ` Jon Ringle
2015-10-05 13:16 ` David Miller
2015-10-05 14:25 ` Mark Brown
2015-10-06 6:21 ` David Miller
2015-10-06 9:57 ` Mark Brown
2015-10-06 13:22 ` David Miller
2015-10-06 15:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005.040042.705688813405698539.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jon@ringle.org \
--cc=jringle@gridpoint.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).