From: David Miller <davem@davemloft.net>
To: clsoto@linux.vnet.ibm.com
Cc: ogerlitz@mellanox.com, netdev@vger.kernel.org,
brking@linux.vnet.ibm.com, amirv@mellanox.com
Subject: Re: [PATCH net-next] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq
Date: Mon, 05 Oct 2015 23:24:05 -0700 (PDT) [thread overview]
Message-ID: <20151005.232405.779019414670229234.davem@davemloft.net> (raw)
In-Reply-To: <56129623.3060800@linux.vnet.ibm.com>
From: Carol Soto <clsoto@linux.vnet.ibm.com>
Date: Mon, 5 Oct 2015 10:24:19 -0500
>
>
> On 10/4/2015 3:03 AM, Or Gerlitz wrote:
>> On 9/29/2015 9:38 PM, clsoto@linux.vnet.ibm.com wrote:
>>> From: Carol L Soto <clsoto@linux.vnet.ibm.com>
>>>
>>> Test interrupts fails if not all completion vectors called
>>> request_irq. This case can happen if only mlx4_en loads and
>>> we have more completion vectors than rx rings.
>>
>> good catch! is this a bug since the driver 0-day or was introduced by
>> some recent commit? in the latercase, please add a Fixes: tag before
>> your S.O.B note.
> Probably the issue was introduced by this one
> Fixes: c66fa19c405a ('net/mlx4: Add EQ pool')
Please resubmit this patch with the Fixes: tag properly
added, thanks.
next prev parent reply other threads:[~2015-10-06 6:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 18:38 [PATCH net-next] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq clsoto
2015-10-04 8:03 ` Or Gerlitz
2015-10-05 15:24 ` Carol Soto
2015-10-06 6:24 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-10-05 20:12 Or Gerlitz
2015-10-06 7:28 ` Matan Barak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005.232405.779019414670229234.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.com \
--cc=brking@linux.vnet.ibm.com \
--cc=clsoto@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).