From: Thomas Graf <tgraf@suug.ch>
To: Pravin B Shelar <pshelar@nicira.com>
Cc: netdev@vger.kernel.org, tomasz.sawicki@objectiveintegration.uk
Subject: Re: [PATCH net] openvswitch: Fix ovs_vport_get_stats()
Date: Mon, 5 Oct 2015 14:31:50 +0200 [thread overview]
Message-ID: <20151005123150.GE5490@pox.localdomain> (raw)
In-Reply-To: <1443822994-1928-1-git-send-email-pshelar@nicira.com>
On 10/02/15 at 02:56pm, Pravin B Shelar wrote:
> Not every device has dev->tstats set. So when OVS tries to calculate
> vport stats it causes kernel panic. Following patch fixes it by
> using standard API to get net-device stats.
>
> ---8<---
> Unable to handle kernel paging request at virtual address 766b4008
> Internal error: Oops: 96000005 [#1] PREEMPT SMP
> Modules linked in: vport_vxlan vxlan ip6_udp_tunnel udp_tunnel tun bridge stp llc openvswitch ipv6
> CPU: 7 PID: 1108 Comm: ovs-vswitchd Not tainted 4.3.0-rc3+ #82
> PC is at ovs_vport_get_stats+0x150/0x1f8 [openvswitch]
> <snip>
> Call trace:
> [<ffffffbffc0859f8>] ovs_vport_get_stats+0x150/0x1f8 [openvswitch]
> [<ffffffbffc07cdb0>] ovs_vport_cmd_fill_info+0x140/0x1e0 [openvswitch]
> [<ffffffbffc07cf0c>] ovs_vport_cmd_dump+0xbc/0x138 [openvswitch]
> [<ffffffc00045a5ac>] netlink_dump+0xb8/0x258
> [<ffffffc00045ace0>] __netlink_dump_start+0x120/0x178
> [<ffffffc00045dd9c>] genl_family_rcv_msg+0x2d4/0x308
> [<ffffffc00045de58>] genl_rcv_msg+0x88/0xc4
> [<ffffffc00045cf24>] netlink_rcv_skb+0xd4/0x100
> [<ffffffc00045dab0>] genl_rcv+0x30/0x48
> [<ffffffc00045c830>] netlink_unicast+0x154/0x200
> [<ffffffc00045cc9c>] netlink_sendmsg+0x308/0x364
> [<ffffffc00041e10c>] sock_sendmsg+0x14/0x2c
> [<ffffffc000420d58>] SyS_sendto+0xbc/0xf0
> Code: aa1603e1 f94037a4 aa1303e2 aa1703e0 (f9400465)
>
> Reported-by: Tomasz Sawicki <tomasz.sawicki@objectiveintegration.uk>
> Fixes: 8c876639c98 ("openvswitch: Remove vport stats.")
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
next prev parent reply other threads:[~2015-10-05 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 21:56 [PATCH net] openvswitch: Fix ovs_vport_get_stats() Pravin B Shelar
2015-10-05 12:31 ` Thomas Graf [this message]
2015-10-05 14:07 ` David Miller
2015-10-15 14:54 ` [PATCH 2/2] openvswitch: Allocate memory for ovs internal device stats James Morse
2015-10-15 17:19 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005123150.GE5490@pox.localdomain \
--to=tgraf@suug.ch \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=tomasz.sawicki@objectiveintegration.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox