From: "Peter Nørlund" <pch@ordbogen.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH net-next] Fixes: 0e884c7 ipv4: L3 hash-based multipath: tag
Date: Tue, 6 Oct 2015 07:21:03 +0200 [thread overview]
Message-ID: <20151006072103.46aa2266@tyr> (raw)
In-Reply-To: <5612F84E.1030709@gmail.com>
On Mon, 5 Oct 2015 15:23:10 -0700
Alexander Duyck <alexander.duyck@gmail.com> wrote:
> Normally the correct comment would include something like the
> following just before the signed-off-by line.
> Fixes: 0e884c78ee19 ("ipv4: L3 hash-based multipath")
>
Got it - I misunderstood the format. I'll submit a revised patch in just
a sec.
> I'm also kind of curious. Why use 2147483648LL instead of just
> casting w as a u64 and shifting by 31? It seems like that would be
> more readable.
I thought about it it creating the fix patch, but thought I'd better
keep the changes small. I'll use shift in the revised patch.
Best Regards
Peter Nørlund
prev parent reply other threads:[~2015-10-06 5:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 22:14 [PATCH net-next] Fixes: 0e884c7 ipv4: L3 hash-based multipath: tag Peter Nørlund
2015-10-05 22:23 ` Alexander Duyck
2015-10-05 23:35 ` Tom Herbert
2015-10-06 5:21 ` Peter Nørlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006072103.46aa2266@tyr \
--to=pch@ordbogen.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).