From: Simon Horman <horms@verge.net.au>
To: David Miller <davem@davemloft.net>
Cc: cwang@twopensource.com, dsa@cumulusnetworks.com,
netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH net-next v2] net: Fix unused variable compile warning
Date: Wed, 7 Oct 2015 10:02:40 +0900 [thread overview]
Message-ID: <20151007010237.GD21067@verge.net.au> (raw)
In-Reply-To: <20151005.233537.1854084467334631982.davem@davemloft.net>
On Mon, Oct 05, 2015 at 11:35:37PM -0700, David Miller wrote:
> From: Cong Wang <cwang@twopensource.com>
> Date: Mon, 5 Oct 2015 10:53:57 -0700
>
> > On Thu, Oct 1, 2015 at 8:49 AM, David Ahern <dsa@cumulusnetworks.com> wrote:
> >> Eric's net namespace changes in 1b75097dd7a26 leaves net unreferenced if
> >> CONFIG_IP_VS_IPV6 is not enabled:
> >>
> >> ../net/netfilter/ipvs/ip_vs_core.c: In function ‘ip_vs_out’:
> >> ../net/netfilter/ipvs/ip_vs_core.c:1177:14: warning: unused variable ‘net’ [-Wunused-variable]
> >>
> >> After the net refactoring there is only 1 user; push the reference to the
> >> 1 user. While the line length slightly exceeds 80 it seems to be the
> >> best change.
> >>
> >> Fixes: 1b75097dd7a26("ipvs: Pass ipvs into ip_vs_out")
> >> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
> >
> > I saw the same build warning, and this fix looks good to me.
> >
> > DaveM, can you take this?
>
> It should be submitted to netfilter-devel and Pablo should take it.
lvs-devel would be better yet.
I submitted an identical patch there yesterday.
I'll pick up David's version and send it to Pablo ASAP.
next prev parent reply other threads:[~2015-10-07 1:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 15:49 [PATCH net-next v2] net: Fix unused variable compile warning David Ahern
2015-10-05 17:53 ` Cong Wang
2015-10-06 6:35 ` David Miller
2015-10-07 1:02 ` Simon Horman [this message]
2015-10-07 2:19 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007010237.GD21067@verge.net.au \
--to=horms@verge.net.au \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).