From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v2 00/13] rocker: add support for multiple worlds Date: Wed, 7 Oct 2015 19:39:56 +0200 Message-ID: <20151007173956.GI2152@nanopsycho.orion> References: <1444067046-27825-1-git-send-email-jiri@resnulli.us> <20151006073018.GA2165@nanopsycho.orion> <20151007060355.GA2152@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Netdev , "David S. Miller" , Ido Schimmel , eladr@mellanox.com, Thomas Graf , Alexei Starovoitov , David Laight , john fastabend To: Scott Feldman Return-path: Received: from mail-wi0-f175.google.com ([209.85.212.175]:36709 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755203AbbJGRj7 (ORCPT ); Wed, 7 Oct 2015 13:39:59 -0400 Received: by wicgb1 with SMTP id gb1so221943663wic.1 for ; Wed, 07 Oct 2015 10:39:58 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Wed, Oct 07, 2015 at 06:53:22PM CEST, sfeldma@gmail.com wrote: >On Tue, Oct 6, 2015 at 11:03 PM, Jiri Pirko wrote: >> Tue, Oct 06, 2015 at 07:14:39PM CEST, sfeldma@gmail.com wrote: >>>On Tue, Oct 6, 2015 at 12:30 AM, Jiri Pirko wrote: >>>> Tue, Oct 06, 2015 at 05:56:12AM CEST, sfeldma@gmail.com wrote: >>>>>On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko wrote: >>>>>> From: Jiri Pirko >>>>>> >>>>>> This patchset allows new rocker worlds to be easily added in future (like eBPF >>>>>> based one I have been working on). The main part of the patchset is the OF-DPA >>>>>> carve-out. It resuts in OF-DPA specific file. Clean cut. >>>>>> >>>>>> v1->v2: >>>>>> - rtnl rocker mode change userspace expose patch was removed >>>>>> >>>>>> Jiri Pirko (13): >>>>>> rocker: remove unused rocker_port param from alloc funcs and shorten >>>>>> their names >>>>>> rocker: rename rocker.h to rocker_hw.h >>>>>> rocker: rename rocker.c to rocker_main.c >>>>>> rocker: push tlv processing into separate files >>>>>> rocker: implement set settings mode command >>>>>> rocker: introduce worlds infrastructure >>>>>> rocker: introduce OF-DPA world skeleton >>>>>> rocker: set default world on port probe and clean world on remove >>>>>> rocker: pass "learning" value as a parameter to >>>>>> rocker_port_set_learning >>>>>> rocker: pre-allocate wait structures during cmd ring init >>>>>> rocker: remove trans parameter to rocker_cmd_exec function >>>>>> rocker: call rocker_cmd_exec function with "nowait" boolean instead of >>>>>> flags >>>>>> rocker: move OF-DPA stuff into separate file >>>>> >>>>>A couple of my tests are failing with this patchset. A simple port >>>>>test is failing and IPv4 routing test is failing. >>>>> >>>>>The port test is simple: just connect a port on DUT to a port on >>>>>another system and assign an IP address to each port and verify IP >>>>>connectivity. I have this: >>>>> >>>>> DUT:sw1p1 (11.0.0.1/24) <-----------> host1:eth0 (11.0.0.2/24) >>>>> >>>>>The IPv4 routing tests is a bit more complicated to setup. I'm using >>>>>OSPF, but I'm not seeing full routes formed in the topology, so I >>>>>suspect OSPF hellos aren't getting thru. >>>>> >>>>>Please fix find/fix these issues and send v3. I don't want any git >>>>>bisect issues when running tests. Thanks. >>>> >>>> I fixed that. Sending v3 in a sec. Thanks. >>> >>>Sorry, both tests are still broken. Would you send me your tests >>>scripts so I can see why your tests are passing? >> >> I'm trying some smoke tests including bridge setup and just ip-ip >> setup by hand. Meybe if you send me your scripts, I can run it locally. > >My test scripts are already included in the qemu tree. Okay, will rework and use your scripts. Hope I will find some time during this weekend. Thanks.