From: Jiri Benc <jbenc@redhat.com>
To: Andreas Schultz <aschultz@tpip.net>
Cc: netdev@vger.kernel.org, Pravin B Shelar <pshelar@nicira.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net v2] fix return of iptunnel_xmit
Date: Thu, 8 Oct 2015 17:08:49 +0200 [thread overview]
Message-ID: <20151008170849.22bc8632@griffin> (raw)
In-Reply-To: <1444299114-21345-1-git-send-email-aschultz@tpip.net>
On Thu, 8 Oct 2015 12:11:54 +0200, Andreas Schultz wrote:
> All users of iptunnel_xmit expect the return value to be the error
> code from ip_output_local, but currently the return value is length
> of the send data on success or zero on error.
> Change iptunnel_xmit returns to match the callers expectation.
That's not true. All users pass the returned value to
iptunnel_xmit_stats() where it is used to increase tx_bytes.
The only exception is tipc_udp_send_msg which should be fixed instead.
Jiri
--
Jiri Benc
next prev parent reply other threads:[~2015-10-08 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 10:11 [PATCH net v2] fix return of iptunnel_xmit Andreas Schultz
2015-10-08 15:08 ` Jiri Benc [this message]
2015-10-08 15:33 ` Andreas Schultz
2015-10-08 15:39 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008170849.22bc8632@griffin \
--to=jbenc@redhat.com \
--cc=aschultz@tpip.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).