From: David Miller <davem@davemloft.net>
To: paul.gortmaker@windriver.com
Cc: netdev@vger.kernel.org, ast@plumgrid.com, anish@chelsio.com,
kraig@google.com, daniel@iogearbox.net, edumazet@google.com,
jhs@mojatatu.com, john.r.fastabend@intel.com,
nicolas.dichtel@6wind.com, ogerlitz@mellanox.com,
shanim@mellanox.com, varkabhadram@gmail.com
Subject: Re: [PATCH-next v2 0/4] make non-modular code explicitly non-modular
Date: Fri, 09 Oct 2015 07:52:57 -0700 (PDT) [thread overview]
Message-ID: <20151009.075257.1072002884119004986.davem@davemloft.net> (raw)
In-Reply-To: <1444253266-22012-1-git-send-email-paul.gortmaker@windriver.com>
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Wed, 7 Oct 2015 17:27:42 -0400
> [v2: drop m68k patches that Geert converted to modules; add one ARM
> driver patch ; update net-next baseline to today; switch to ARM
> for build testing.]
>
> In a previous merge window, we made changes to allow better
> delineation between modular and non-modular code in commit
> 0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init
> from init.h to module.h"). This allows us to now ensure module code
> looks modular and non-modular code does not accidentally look modular
> just to avoid suffering build breakage.
>
> Here we target code that is, by nature of their Makefile and/or
> Kconfig settings, only available to be built-in, but implicitly
> presenting itself as being possibly modular by way of using modular
> headers, macros, and functions.
>
> The goal here is to remove that illusion of modularity from these
> files, but in a way that leaves the actual runtime unchanged.
> In doing so, we remove code that has never been tested and adds
> no value to the tree. And we continue the process of expecting a
> level of consistency between the Kconfig/Makefile of code and the
> code in use itself.
>
> Fortuntately the net subsystem has relatively few instances, given
> the overall amount of code and drivers it contains. For comparison
> there are over 300 instances tree wide, resulting in a possible net
> removal of on the order of 5000 lines of unused code.
>
> Build tested on net-next from today, on ARM, since that is the arch
> where the one ethernet driver changed here is available.
Series applied, thanks Paul.
prev parent reply other threads:[~2015-10-09 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 21:27 [PATCH-next v2 0/4] make non-modular code explicitly non-modular Paul Gortmaker
2015-10-07 21:27 ` [PATCH-next v2 1/4] net/core: make sock_diag.c " Paul Gortmaker
2015-10-07 21:27 ` [PATCH-next v2 2/4] net/dcb: make dcbnl.c " Paul Gortmaker
2015-10-07 21:27 ` [PATCH-next v2 3/4] net/sched: make sch_blackhole.c " Paul Gortmaker
2015-10-07 21:47 ` Cong Wang
2015-10-08 22:59 ` Paul Gortmaker
2015-10-07 21:27 ` [PATCH-next v2 4/4] drivers/net/ethernet: make ti/cpsw-phy-sel.c " Paul Gortmaker
2015-10-09 14:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009.075257.1072002884119004986.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anish@chelsio.com \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=john.r.fastabend@intel.com \
--cc=kraig@google.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=ogerlitz@mellanox.com \
--cc=paul.gortmaker@windriver.com \
--cc=shanim@mellanox.com \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).