From: Steffen Klassert <steffen.klassert@secunet.com>
To: Hajime Tazaki <thehajime@gmail.com>
Cc: <dsa@cumulusnetworks.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6
Date: Fri, 9 Oct 2015 09:17:10 +0200 [thread overview]
Message-ID: <20151009071710.GJ7701@secunet.com> (raw)
In-Reply-To: <m2a8rs7crl.wl@gmail.com>
On Fri, Oct 09, 2015 at 03:54:22PM +0900, Hajime Tazaki wrote:
>
> Hello David,
>
> At Mon, 5 Oct 2015 08:32:51 -0600,
> David Ahern wrote:
>
> >
> > diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c
> > index 30caa289c5db..5cedfda4b241 100644
> > --- a/net/ipv6/xfrm6_policy.c
> > +++ b/net/ipv6/xfrm6_policy.c
> > @@ -37,6 +37,7 @@ static struct dst_entry *xfrm6_dst_lookup(struct net *net, int tos, int oif,
> >
> > memset(&fl6, 0, sizeof(fl6));
> > fl6.flowi6_oif = oif;
> > + fl6.flowi6_flags = FLOWI_FLAG_SKIP_NH_OIF;
> > memcpy(&fl6.daddr, daddr, sizeof(fl6.daddr));
> > if (saddr)
> > memcpy(&fl6.saddr, saddr, sizeof(fl6.saddr));
>
> I found that this fix is still not sufficient with the mip6
> (Mobile IPv6) use case.
It does not even fix the vti case. The behaviour of the vti devices is
the same, with and without the patch.
next prev parent reply other threads:[~2015-10-09 7:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 14:32 [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6 David Ahern
2015-10-07 11:25 ` David Miller
2015-10-07 14:12 ` David Ahern
2015-10-09 6:54 ` Hajime Tazaki
2015-10-09 7:17 ` Steffen Klassert [this message]
2015-10-09 15:53 ` David Ahern
2015-10-09 17:27 ` David Ahern
2015-10-11 13:22 ` Hajime Tazaki
2015-10-11 13:31 ` David Ahern
2015-10-11 14:24 ` Hajime Tazaki
2015-10-11 18:01 ` David Ahern
2015-10-20 12:31 ` Hajime Tazaki
2015-10-20 17:48 ` David Ahern
2015-10-21 2:38 ` Hajime Tazaki
2015-10-12 18:49 ` David Ahern
2015-10-13 14:34 ` Steffen Klassert
2015-10-19 8:01 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009071710.GJ7701@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=thehajime@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).