From: kbuild test robot <lkp@intel.com>
To: Michael Chan <mchan@broadcom.com>
Cc: kbuild-all@01.org, davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH] bnxt_en: fix array_size.cocci warnings
Date: Sat, 10 Oct 2015 20:24:22 +0800 [thread overview]
Message-ID: <20151010122421.GA58237@ivytown2> (raw)
In-Reply-To: <1444477151-2225-1-git-send-email-mchan@broadcom.com>
drivers/net/ethernet/broadcom/bnxt/bnxt.c:2773:41-42: WARNING: Use ARRAY_SIZE
Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element
Semantic patch information:
This makes an effort to find cases where ARRAY_SIZE can be used such as
where there is a division of sizeof the array by the sizeof its first
element or by any indexed element or the element type. It replaces the
division of the two sizeofs by ARRAY_SIZE.
Generated by: scripts/coccinelle/misc/array_size.cocci
CC: Michael Chan <mchan@broadcom.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
bnxt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -2770,8 +2770,7 @@ static int bnxt_hwrm_func_drv_rgtr(struc
u32 *data = (u32 *)vf_req_snif_bmap;
memset(vf_req_snif_bmap, 0, 32);
- for (i = 0; i < sizeof(bnxt_vf_req_snif) /
- sizeof(bnxt_vf_req_snif[0]); i++)
+ for (i = 0; i < ARRAY_SIZE(bnxt_vf_req_snif); i++)
__set_bit(bnxt_vf_req_snif[i], vf_req_snif_bmap);
for (i = 0; i < 8; i++) {
next prev parent reply other threads:[~2015-10-10 12:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-10 11:39 [PATCH net-next] bnxt_en: New Broadcom ethernet driver Michael Chan
2015-10-10 12:23 ` kbuild test robot
2015-10-10 12:24 ` kbuild test robot
2015-10-10 12:24 ` [PATCH] bnxt_en: fix simple_return.cocci warnings kbuild test robot
2015-10-10 12:24 ` [PATCH] bnxt_en: fix returnvar.cocci warnings kbuild test robot
2015-10-10 12:24 ` kbuild test robot
2015-10-10 12:24 ` kbuild test robot [this message]
2015-10-10 12:24 ` [PATCH] bnxt_en: fix semicolon.cocci warnings kbuild test robot
2015-10-10 12:24 ` [PATCH] bnxt_en: fix simple_return.cocci warnings kbuild test robot
2015-10-10 15:51 ` [PATCH net-next] bnxt_en: New Broadcom ethernet driver Joe Perches
2015-10-10 17:00 ` kbuild test robot
2015-10-10 19:17 ` kbuild test robot
2015-10-11 6:54 ` Dmitry Kravkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151010122421.GA58237@ivytown2 \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=kbuild-all@01.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).