From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] bnxt_en: fix returnvar.cocci warnings Date: Sat, 10 Oct 2015 20:24:22 +0800 Message-ID: <20151010122422.GA58534@ivytown2> References: <201510102046.oAPUHudL%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, davem@davemloft.net, netdev@vger.kernel.org To: Michael Chan Return-path: Received: from mga03.intel.com ([134.134.136.65]:50624 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbbJJMZc (ORCPT ); Sat, 10 Oct 2015 08:25:32 -0400 Content-Disposition: inline In-Reply-To: <1444477151-2225-1-git-send-email-mchan@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:521:5-7: Unneeded variable: "rc". Return "0" on line 595 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Michael Chan Signed-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! bnxt_ethtool.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -518,7 +518,6 @@ u32 bnxt_fw_to_ethtool_speed(u16 fw_link static int bnxt_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) { - int rc = 0; struct bnxt *bp = netdev_priv(dev); struct bnxt_link_info *link_info = &bp->link_info; u16 ethtool_speed; @@ -592,7 +591,7 @@ static int bnxt_get_settings(struct net_ cmd->transceiver = XCVR_EXTERNAL; cmd->phy_address = link_info->phy_addr; - return rc; + return 0; } static u32 bnxt_get_fw_speed(struct net_device *dev, u16 ethtool_speed)