From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] bnxt_en: fix simple_return.cocci warnings Date: Sat, 10 Oct 2015 20:24:22 +0800 Message-ID: <20151010122422.GA58821@ivytown2> References: <201510102046.oAPUHudL%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, davem@davemloft.net, netdev@vger.kernel.org To: Michael Chan Return-path: Received: from mga02.intel.com ([134.134.136.20]:52469 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbbJJM0D (ORCPT ); Sat, 10 Oct 2015 08:26:03 -0400 Content-Disposition: inline In-Reply-To: <1444477151-2225-1-git-send-email-mchan@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: drivers/net/ethernet/broadcom/bnxt/bnxt.c:4071:1-3: WARNING: end returns can be simpified and declaration on line 4064 can be dropped Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Michael Chan Signed-off-by: Fengguang Wu --- bnxt.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -4061,18 +4061,12 @@ static int bnxt_shutdown_nic(struct bnxt static int bnxt_init_nic(struct bnxt *bp, bool irq_re_init) { - int rc; - bnxt_init_rx_rings(bp); bnxt_init_tx_rings(bp); bnxt_init_ring_grps(bp, irq_re_init); bnxt_init_vnics(bp); - rc = bnxt_init_chip(bp, irq_re_init); - if (rc) - return rc; - - return 0; + return bnxt_init_chip(bp, irq_re_init); } static void bnxt_disable_int(struct bnxt *bp)