From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] bnxt_en: fix simple_return.cocci warnings Date: Sat, 10 Oct 2015 20:24:23 +0800 Message-ID: <20151010122422.GA58962@ivytown2> References: <201510102046.oAPUHudL%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, davem@davemloft.net, netdev@vger.kernel.org To: Michael Chan Return-path: Received: from mga09.intel.com ([134.134.136.24]:46590 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbbJJMZm (ORCPT ); Sat, 10 Oct 2015 08:25:42 -0400 Content-Disposition: inline In-Reply-To: <1444477151-2225-1-git-send-email-mchan@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:156:1-3: WARNING: end returns can be simpified and declaration on line 154 can be dropped drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:140:1-3: WARNING: end returns can be simpified and declaration on line 138 can be dropped Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Michael Chan Signed-off-by: Fengguang Wu --- bnxt_sriov.c | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c @@ -135,31 +135,16 @@ int bnxt_set_vf_mac(struct net_device *d int bnxt_set_vf_vlan(struct net_device *dev, int vf_id, u16 vlan_id, u8 qos) { struct bnxt *bp = netdev_priv(dev); - int rc; - rc = bnxt_vf_ndo_prep(bp, vf_id); - if (rc) - return rc; - - /* CHIMP TODO: send hwrm_func_cfg msg to set new vlan */ - - - return 0; + return bnxt_vf_ndo_prep(bp, vf_id); } int bnxt_set_vf_bw(struct net_device *dev, int vf_id, int tx_rate_rate, int max_tx_rate) { struct bnxt *bp = netdev_priv(dev); - int rc; - - rc = bnxt_vf_ndo_prep(bp, vf_id); - if (rc) - return rc; - - /* CHIMP TODO: send hwrm_func_cfg msg to set new bandwidth */ - return 0; + return bnxt_vf_ndo_prep(bp, vf_id); } int bnxt_set_vf_link_state(struct net_device *dev, int vf_id, int link)