From: Jiri Pirko <jiri@resnulli.us>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
bridge@lists.linux-foundation.org, davem@davemloft.net,
eladr@mellanox.com,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH net-next] bridge: vlan: enforce no pvid flag in vlan ranges
Date: Sun, 11 Oct 2015 16:13:26 +0200 [thread overview]
Message-ID: <20151011141326.GA2080@nanopsycho> (raw)
In-Reply-To: <1444560596-7140-1-git-send-email-razor@blackwall.org>
Sun, Oct 11, 2015 at 12:49:56PM CEST, razor@blackwall.org wrote:
>From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
>Currently it's possible for someone to send a vlan range to the kernel
>with the pvid flag set which will result in the pvid bouncing from a
>vlan to vlan and isn't correct, it also introduces problems for hardware
>where it doesn't make sense having more than 1 pvid. iproute2 already
>enforces this, so let's enforce it on kernel-side as well.
>
>Reported-by: Elad Raz <eladr@mellanox.com>
>Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
next prev parent reply other threads:[~2015-10-11 14:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 23:30 switchdev and VLAN ranges Vivien Didelot
2015-10-10 4:22 ` Scott Feldman
2015-10-10 16:33 ` Vivien Didelot
2015-10-10 18:10 ` Florian Fainelli
2015-10-10 19:47 ` Vivien Didelot
2015-10-10 7:49 ` Elad Raz
2015-10-10 10:36 ` Nikolay Aleksandrov
2015-10-11 7:12 ` Jiri Pirko
2015-10-11 10:49 ` [PATCH net-next] bridge: vlan: enforce no pvid flag in vlan ranges Nikolay Aleksandrov
2015-10-11 14:13 ` Jiri Pirko [this message]
2015-10-13 2:59 ` David Miller
2015-10-11 22:41 ` switchdev and VLAN ranges Vivien Didelot
2015-10-12 0:13 ` Nikolay Aleksandrov
2015-10-12 5:14 ` Scott Feldman
2015-10-12 10:15 ` Nikolay Aleksandrov
2015-10-12 12:01 ` [PATCH net-next] switchdev: enforce no pvid flag in vlan ranges Nikolay Aleksandrov
2015-10-12 12:11 ` Elad Raz
2015-10-12 12:17 ` Jiri Pirko
2015-10-12 17:36 ` Vivien Didelot
2015-10-13 6:13 ` Scott Feldman
2015-10-13 8:31 ` Ido Schimmel
2015-10-13 14:32 ` Vivien Didelot
2015-10-14 6:14 ` Ido Schimmel
2015-10-14 15:25 ` Vivien Didelot
2015-10-14 17:14 ` Scott Feldman
2015-10-14 17:42 ` Ido Schimmel
2015-10-14 18:51 ` Vivien Didelot
2015-10-14 22:08 ` Florian Fainelli
2015-10-15 0:07 ` Vivien Didelot
2015-10-15 2:58 ` Scott Feldman
2015-10-15 7:28 ` Ido Schimmel
2015-10-13 11:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151011141326.GA2080@nanopsycho \
--to=jiri@resnulli.us \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=razor@blackwall.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).