From: Stephen Hemminger <stephen@networkplumber.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH 0/3] improve MACVLAN/MACVTAP support
Date: Mon, 12 Oct 2015 09:48:13 -0700 [thread overview]
Message-ID: <20151012094813.19ee60ea@urahara> (raw)
In-Reply-To: <1443182991-4628-1-git-send-email-phil@nwl.cc>
On Fri, 25 Sep 2015 14:09:48 +0200
Phil Sutter <phil@nwl.cc> wrote:
> While implementing support for MACVLAN_FLAG_NOPROMISC, I realized how similar
> iplink_macvlan.c and iplink_macvtap.c are and that the main differences (apart
> from substituting "macvlan" for "macvtap") were fixes and enhancements which
> weren't applied to both files. To prevent this in the future and to share
> common code, this series merges the files. In addition, it implements support
> for MACVLAN_FLAG_NOPROMISC and finally documents these interface types in
> ip-link.8.in.
>
> Phil Sutter (3):
> ip: link: consolidate macvlan and macvtap
> ip: macvlan: support MACVLAN_FLAG_NOPROMISC flag
> man: ip-link: document MACVLAN/MACVTAP interface types
>
> ip/Makefile | 2 +-
> ip/iplink_macvlan.c | 68 ++++++++++++++++++++++++--------
> ip/iplink_macvtap.c | 105 --------------------------------------------------
> man/man8/ip-link.8.in | 50 ++++++++++++++++++++++++
> 4 files changed, 104 insertions(+), 121 deletions(-)
> delete mode 100644 ip/iplink_macvtap.c
>
Looks good applied. Always love to see more code deleted..
prev parent reply other threads:[~2015-10-12 16:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 12:09 [iproute PATCH 0/3] improve MACVLAN/MACVTAP support Phil Sutter
2015-09-25 12:09 ` [iproute PATCH 1/3] ip: link: consolidate macvlan and macvtap Phil Sutter
2015-09-25 12:09 ` [iproute PATCH 2/3] ip: macvlan: support MACVLAN_FLAG_NOPROMISC flag Phil Sutter
2015-09-25 12:09 ` [iproute PATCH 3/3] man: ip-link: document MACVLAN/MACVTAP interface types Phil Sutter
2015-10-12 16:48 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012094813.19ee60ea@urahara \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).